Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chromeos/dbus/session_manager_client.h

Issue 2310823003: chromeos: Remove dbus::FileDescriptor from SessionManagerClient (Closed)
Patch Set: Fix test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/session_manager_client.h
diff --git a/chromeos/dbus/session_manager_client.h b/chromeos/dbus/session_manager_client.h
index c722a6e03190f6857e8f69fe9be13fd1b703c6bc..01b8c841cd729fcc3e152cb8b54881b3f9f5f8c3 100644
--- a/chromeos/dbus/session_manager_client.h
+++ b/chromeos/dbus/session_manager_client.h
@@ -15,6 +15,7 @@
#include "chromeos/chromeos_export.h"
#include "chromeos/dbus/dbus_client.h"
#include "chromeos/dbus/dbus_client_implementation_type.h"
+#include "chromeos/dbus/dbus_method_call_status.h"
namespace cryptohome {
class Identification;
@@ -84,7 +85,15 @@ class CHROMEOS_EXPORT SessionManagerClient : public DBusClient {
virtual void EmitLoginPromptVisible() = 0;
// Restarts the browser job, passing |argv| as the updated command line.
- virtual void RestartJob(const std::vector<std::string>& argv) = 0;
+ // The session manager requires a RestartJob caller to open a socket pair and
+ // pass one end while holding the local end open for the duration of the call.
+ // The session manager uses this to determine whether the PID the restart
+ // request originates from belongs to the browser itself.
+ // This method duplicates |socket_fd| so it's OK to close the FD without
+ // waiting for the result.
+ virtual void RestartJob(int socket_fd,
+ const std::vector<std::string>& argv,
+ const VoidDBusMethodCallback& callback) = 0;
// Starts the session for the user.
virtual void StartSession(

Powered by Google App Engine
This is Rietveld 408576698