Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2310823002: Skeleton implementation of CSS Properties and Values API (Closed)

Created:
4 years, 3 months ago by Timothy Loh
Modified:
4 years, 3 months ago
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, blink-reviews-bindings_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skeleton implementation of CSS Properties and Values API This patch provides a basic skeleton implementation of the CSS Properties and Values API. In particular, the pipeline from registration to reading from computed styles is supported but with many missing bits along the way. Some of the missing bits: - Only * and <length> syntax supported with trivial parsing logic. - All properties assumed to be inherited. - Computation logic is currently a no-op (needs to resolve ems, etc.) - CSSOM on specified styles aren't yet affected by (un)registration Spec: https://drafts.css-houdini.org/css-properties-values-api/ Design notes: https://docs.google.com/document/d/1IBT3qlZK-BznqcVANckj6kjMjpyFHc-KHdBLz1n4M4c BUG=641877 Committed: https://crrev.com/01ce431409e3a019858677626a983c55168da6dc Cr-Commit-Position: refs/heads/master@{#417240}

Patch Set 1 #

Patch Set 2 : custom properties :D #

Patch Set 3 : custom properties :D #

Total comments: 1

Patch Set 4 : custom properties :D #

Total comments: 7

Patch Set 5 : fix #

Patch Set 6 : fix gCS for vars with flag off #

Patch Set 7 : tweak checks #

Patch Set 8 : rebase #

Patch Set 9 : fix stylevardata copy ctor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+631 lines, -32 lines) Patch
A third_party/WebKit/LayoutTests/custom-properties/register-property.html View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/custom-properties/unregister-property.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/custom-properties/var-reference-registered-properties.html View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/custom-properties/var-reference-registered-properties-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/BUILD.gn View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.h View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp View 1 2 3 1 chunk +67 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSVariableData.h View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSVariableData.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 3 4 5 6 2 chunks +14 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/core/css/PropertyDescriptor.idl View 1 chunk +5 lines, -8 lines 0 comments Download
A third_party/WebKit/Source/core/css/PropertyRegistration.h View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/PropertyRegistration.cpp View 1 1 chunk +87 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/PropertyRegistration.idl View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/PropertyRegistry.h View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/PropertyRegistry.cpp View 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSVariableParser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp View 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp View 1 6 chunks +36 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 chunks +31 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 2 3 4 5 6 7 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 4 5 6 7 3 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleChangeReason.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleChangeReason.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 4 5 6 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleVariableData.h View 3 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleVariableData.cpp View 1 2 3 4 5 6 7 8 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 44 (35 generated)
Timothy Loh
alancutter: LMK if I'll need to change anything to make this more compatible with the ...
4 years, 3 months ago (2016-09-05 07:19:42 UTC) #7
meade_UTC10
The general shape lgtm, looks like you still have some failing bots though https://codereview.chromium.org/2310823002/diff/60001/third_party/WebKit/Source/core/css/PropertyRegistration.idl File ...
4 years, 3 months ago (2016-09-06 04:52:07 UTC) #14
alancutter (OOO until 2018)
At a glance the challenges for animations in integrating with this will be: - the ...
4 years, 3 months ago (2016-09-06 05:40:15 UTC) #15
Timothy Loh
https://codereview.chromium.org/2310823002/diff/60001/third_party/WebKit/Source/core/css/PropertyRegistration.idl File third_party/WebKit/Source/core/css/PropertyRegistration.idl (right): https://codereview.chromium.org/2310823002/diff/60001/third_party/WebKit/Source/core/css/PropertyRegistration.idl#newcode6 third_party/WebKit/Source/core/css/PropertyRegistration.idl:6: [CallWith=ExecutionContext, RaisesException] static void registerProperty(PropertyDescriptor descriptor); On 2016/09/06 04:52:06, ...
4 years, 3 months ago (2016-09-06 08:21:17 UTC) #18
Timothy Loh
haraken, can you stamp Source/bindings and Source/platform changes?
4 years, 3 months ago (2016-09-08 06:31:02 UTC) #32
haraken
On 2016/09/08 06:31:02, Timothy Loh wrote: > haraken, can you stamp Source/bindings and Source/platform changes? ...
4 years, 3 months ago (2016-09-08 07:11:58 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310823002/160001
4 years, 3 months ago (2016-09-08 09:18:36 UTC) #40
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 3 months ago (2016-09-08 09:22:53 UTC) #42
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 09:25:20 UTC) #44
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/01ce431409e3a019858677626a983c55168da6dc
Cr-Commit-Position: refs/heads/master@{#417240}

Powered by Google App Engine
This is Rietveld 408576698