Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2369)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2310753002: Media Remoting: Data/Control plumbing between renderer and Media Router. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index cefdf2ba5537e1728dde9898f84d1cdb75309bea..f0895410216cb22f3e92fd127aa05fb9aef5cf58 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2633,6 +2633,10 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
base::Unretained(render_thread)),
GetMediaInterfaceProvider()));
#else
+ // TODO(miu): In future change, call GetRemoterFactory()->Create() and pass
+ // the media::mojom::RemoterPtr to the media::RendererFactory here so that it
+ // can decide whether to create local media::Renderers or "remoted"
+ // media::Renderers.
xjz 2016/09/09 17:38:48 This seems different from our current design. But
miu 2016/09/11 00:25:22 Updated and moved this TODO comment.
std::unique_ptr<media::RendererFactory> media_renderer_factory =
GetContentClient()->renderer()->CreateMediaRendererFactory(
this, render_thread->GetGpuFactories(), media_log);
@@ -6139,6 +6143,12 @@ bool RenderFrameImpl::AreSecureCodecsSupported() {
#endif // defined(OS_ANDROID)
}
+media::mojom::RemoterFactory* RenderFrameImpl::GetRemoterFactory() {
+ if (!remoter_factory_)
+ GetRemoteInterfaces()->GetInterface(&remoter_factory_);
+ return remoter_factory_.get();
+}
+
media::CdmFactory* RenderFrameImpl::GetCdmFactory() {
if (cdm_factory_)
return cdm_factory_.get();

Powered by Google App Engine
This is Rietveld 408576698