Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2310743002: Reland of Merge method_counts into resource_sizes (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Reland of Merge method_counts into resource_sizes Prev: https://codereview.chromium.org/2309533002/ Reason for reland: src-side fix here: https://codereview.chromium.org/2306263002/ resource_size.py now also reports method counts, so no need to run method_counts.py separately. TBR=rnephew@chromium.org,bpastene@chromium.org,jbudorick@chromium.org BUG=609365 Committed: https://chromium.googlesource.com/chromium/tools/build/+/06ed07eab4801c8605ff0da42d70128f794103a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1361 lines, -1090 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 2 chunks +25 lines, -28 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.py View 3 chunks +3 lines, -15 lines 0 comments Download
D scripts/slave/recipe_modules/chromium_android/example.expected/java_method_count_builder_basic.json View 1 chunk +0 lines, -966 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/resource_size_builder_basic.json View 2 chunks +154 lines, -18 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json View 2 chunks +131 lines, -7 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_armv6_builder.json View 2 chunks +131 lines, -7 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json View 2 chunks +131 lines, -7 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_kitkat_builder.json View 2 chunks +131 lines, -7 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_lollipop_builder.json View 2 chunks +131 lines, -7 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_builder.json View 2 chunks +131 lines, -7 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_perf.json View 2 chunks +131 lines, -7 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_mips_builder.json View 2 chunks +131 lines, -7 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_x86_builder.json View 2 chunks +131 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
agrieve
Created Reland of Merge method_counts into resource_sizes
4 years, 3 months ago (2016-09-04 00:53:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310743002/1
4 years, 3 months ago (2016-09-05 00:14:04 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 00:17:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/06ed07eab4801c8605ff...

Powered by Google App Engine
This is Rietveld 408576698