Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2310733002: Revert of Roll src/third_party/catapult/ 4f812c903..1f08948ad (1 commit). (Closed)

Created:
4 years, 3 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 3 months ago
Reviewers:
sullivan, catapult-deps-roller, catapult-sheriff
CC:
chromium-reviews, catapult-sheriff_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll src/third_party/catapult/ 4f812c903..1f08948ad (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2311593002/ ) Reason for revert: This appears to have broken the Google Chrome Win builder. Original issue's description: > Roll src/third_party/catapult/ 4f812c903..1f08948ad (1 commit). > > https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4f812c9035e6..1f08948ad3a9 > > $ git log 4f812c903..1f08948ad --date=short --no-merges --format='%ad %ae %s' > 2016-09-03 perezju [Telemetry] Expose platform.GetSystemTotalPhysicalMemory > > BUG=637217 > > TBR=catapult-sheriff@chromium.org > > Committed: https://crrev.com/62f4b56e57376b13a7bab82e50ca03c2d5033e63 > Cr-Commit-Position: refs/heads/master@{#416456} TBR=catapult-sheriff@chromium.org,catapult-deps-roller@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=637217 Committed: https://crrev.com/233fa6caaa0206814af3213a04ffe27c914991ec Cr-Commit-Position: refs/heads/master@{#416457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dominicc (has gone to gerrit)
Created Revert of Roll src/third_party/catapult/ 4f812c903..1f08948ad (1 commit).
4 years, 3 months ago (2016-09-03 23:24:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310733002/1
4 years, 3 months ago (2016-09-03 23:24:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-03 23:25:40 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/233fa6caaa0206814af3213a04ffe27c914991ec Cr-Commit-Position: refs/heads/master@{#416457}
4 years, 3 months ago (2016-09-03 23:27:19 UTC) #6
sullivan
Can you please file a bug on crbug.com and cc me and nednguyen, and then ...
4 years, 3 months ago (2016-09-04 00:56:43 UTC) #7
nednguyen
4 years, 3 months ago (2016-09-06 23:07:00 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2313163002/ by nednguyen@google.com.

The reason for reverting is: Roll shouldn't be reverted..

Powered by Google App Engine
This is Rietveld 408576698