Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: test/cctest/test-parsing.cc

Issue 231073002: WIP: Parser: delay string internalization. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index 80a116f1155b592213285f4c7e23182dcfcc0646..389993c8d6ffd1f2c12a80e74b034977be956955 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -37,6 +37,7 @@
#include "isolate.h"
#include "objects.h"
#include "parser.h"
+#include "parser-symbol-table.h"
#include "preparser.h"
#include "scanner-character-streams.h"
#include "token.h"
@@ -796,8 +797,9 @@ void TestScanRegExp(const char* re_source, const char* expected) {
CHECK(start == i::Token::DIV || start == i::Token::ASSIGN_DIV);
CHECK(scanner.ScanRegExpPattern(start == i::Token::ASSIGN_DIV));
scanner.Next(); // Current token is now the regexp literal.
- i::Handle<i::String> val =
- scanner.AllocateInternalizedString(CcTest::i_isolate());
+ i::ParserSymbolTable symbol_table;
+ symbol_table.AlwaysInternalize(CcTest::i_isolate());
+ i::Handle<i::String> val = scanner.CurrentString(&symbol_table)->string();
i::DisallowHeapAllocation no_alloc;
i::String::FlatContent content = val->GetFlatContent();
CHECK(content.IsAscii());
« src/parser-symbol-table.cc ('K') | « src/variables.cc ('k') | tools/gyp/v8.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698