Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/webrtc/webrtc_webcam_browsertest.cc

Issue 2310683003: Removed duplicated JS hasVideoInputDeviceOnSystem() test helper (Closed)
Patch Set: Codereview update Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/webrtc/media_devices.js ('k') | content/public/test/browser_test_utils.h » ('j') | content/public/test/browser_test_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/webrtc/webrtc_webcam_browsertest.cc
diff --git a/content/browser/webrtc/webrtc_webcam_browsertest.cc b/content/browser/webrtc/webrtc_webcam_browsertest.cc
index c0c7ad50e464a91f391c3518f7273fa49ae733a9..5a3430742d7af4aa528acd4f6ddb2d35615b842f 100644
--- a/content/browser/webrtc/webrtc_webcam_browsertest.cc
+++ b/content/browser/webrtc/webrtc_webcam_browsertest.cc
@@ -74,10 +74,8 @@ IN_PROC_BROWSER_TEST_F(WebRtcWebcamBrowserTest,
NavigateToURL(shell(), url);
std::string result;
- ASSERT_TRUE(ExecuteScriptAndExtractString(
- shell(), "hasVideoInputDeviceOnSystem()", &result));
- if (result != "has-video-input-device") {
- VLOG(0) << "No video device; skipping test...";
+ if (!HasWebcamAvailableOnSystem(shell()->web_contents())) {
+ DVLOG(0) << "No video device; skipping test...";
return;
}
« no previous file with comments | « chrome/test/data/webrtc/media_devices.js ('k') | content/public/test/browser_test_utils.h » ('j') | content/public/test/browser_test_utils.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698