Removed duplicated JS hasVideoInputDeviceOnSystem() test helper

content/public/test/browser_test_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_TEST_BROWSER_TEST_UTILS_H_
 #define CONTENT_PUBLIC_TEST_BROWSER_TEST_UTILS_H_
 
 #include <queue>
 #include <string>
 #include <vector>
@@ skipping 148 matching lines @@
 // or the keyboard layout.
 void SimulateKeyPress(WebContents* web_contents,
                       ui::DomKey key,
                       ui::DomCode code,
                       ui::KeyboardCode key_code,
                       bool control,
                       bool shift,
                       bool alt,
                       bool command);
 
+//
+// Queries for video input devices on the current system using the getSources
+// API.
+//
+// This does not guarantee that a getUserMedia with video will succeed, as the
+// camera could be busy for instance.
+//
+// Returns has-video-input-device to the test if there is a webcam available,
+// no-video-input-devices otherwise.
+static const std::string hasVideoInputDeviceOnSystem =

[mcasas, 2016/09/06 15:34:54]

Move this string to the anonymous namespace in the
implementation file.

[lunalu1, 2016/09/06 20:56:13]

Done.

+    "(function() {"
+    "MediaStreamTrack.getSources(function(devices) {"
+    "devices.forEach(function(device) {"
+    "if (device.kind == 'video')"
+    "returnToTest('has-video-input-device');"
+    "});"
+    "returnToTest('no-video-input-devices');"
+    "});"
+    "})()";

[mcasas, 2016/09/06 15:34:54]

Can we indent these lines to make them more readable?

[lunalu1, 2016/09/06 20:56:13]

Done.

+
+// Method to check what devices we have on the system.
+bool HasWebcamAvailableOnSystem(WebContents* tab_contents);
+
 // Allow ExecuteScript* methods to target either a WebContents or a
 // RenderFrameHost.  Targetting a WebContents means executing the script in the
 // RenderFrameHost returned by WebContents::GetMainFrame(), which is the main
 // frame.  Pass a specific RenderFrameHost to target it. Embedders may declare
 // additional ConvertToRenderFrameHost functions for convenience.
 class ToRenderFrameHost {
  public:
   template <typename T>
   ToRenderFrameHost(T* frame_convertible_value)
       : render_frame_host_(ConvertToRenderFrameHost(frame_convertible_value)) {}
@@ skipping 461 matching lines @@
   scoped_refptr<MessageLoopRunner> did_finish_loop_runner_;
 
   base::WeakPtrFactory<TestNavigationManager> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(TestNavigationManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_TEST_BROWSER_TEST_UTILS_H_