Removed duplicated JS hasVideoInputDeviceOnSystem() test helper

content/public/test/browser_test_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/test/browser_test_utils.h"
 
 #include <stddef.h>
 #include <tuple>
 #include <utility>
 
@@ skipping 390 matching lines @@
 
   net::Filter::FilterStatus status;
   do {
     int read_size = kBufferSize;
     status = filter->ReadData(dest_buffer, &read_size);
     ASSERT_NE(status, net::Filter::FILTER_ERROR);
     to_append->append(dest_buffer, read_size);
   } while (status != net::Filter::FILTER_DONE);
 }
 
+// Queries for video input devices on the current system using the getSources
+// API.
+//
+// This does not guarantee that a getUserMedia with video will succeed, as the
+// camera could be busy for instance.
+//
+// Returns has-video-input-device to the test if there is a webcam available,
+// no-video-input-devices otherwise.
+static const std::string hasVideoInputDeviceOnSystem =

[sky, 2016/09/13 21:32:34]

There is no need for the static as this in an anonymous namespace. Style guide
says constants defined like this should be POD (plain old data, aka no objects).
Use a const char[] and you should be fine.
Style guide also says this should be named kFoo.

[lunalu1, 2016/09/13 21:55:02]

Done.

+    "(function() {"
+      "navigator.mediaDevices.enumerateDevices()"
+      ".then(function(devices) {"
+        "devices.forEach(function(device) {"
+          "if (device.kind == 'video') {"
+            "returnToTest('has-video-input-device');"
+            "return;"
+          "}"
+        "});"
+        "returnToTest('no-video-input-devices');"
+      "});"
+    "})()";
+
 }  // namespace
 
 bool NavigateIframeToURL(WebContents* web_contents,
                          std::string iframe_id,
                          const GURL& url) {
   std::string script = base::StringPrintf(
       "setTimeout(\""
       "var iframes = document.getElementById('%s');iframes.src='%s';"
       "\",0)",
       iframe_id.c_str(), url.spec().c_str());
@@ skipping 314 matching lines @@
   if (command) {
     modifiers &= ~blink::WebInputEvent::MetaKey;
     InjectRawKeyEvent(web_contents, blink::WebInputEvent::KeyUp,
                       ui::DomKey::META, ui::DomCode::META_LEFT,
                       ui::VKEY_COMMAND, modifiers);
   }
 
   ASSERT_EQ(modifiers, 0);
 }
 
+bool HasWebcamAvailableOnSystem(WebContents* web_contents) {
+  std::string result;
+  EXPECT_TRUE(content::ExecuteScriptAndExtractString(
+      web_contents, hasVideoInputDeviceOnSystem, &result));
+  return result == "has-video-input-device";

[sky, 2016/09/13 21:32:34]

Can this be a constant?

[lunalu1, 2016/09/13 21:55:02]

Done.

+}
+
 RenderFrameHost* ConvertToRenderFrameHost(WebContents* web_contents) {
   return web_contents->GetMainFrame();
 }
 
 RenderFrameHost* ConvertToRenderFrameHost(RenderViewHost* render_view_host) {
   return render_view_host->GetMainFrame();
 }
 
 RenderFrameHost* ConvertToRenderFrameHost(RenderFrameHost* render_frame_host) {
   return render_frame_host;
@@ skipping 934 matching lines @@
 
 bool TestNavigationManager::ShouldMonitorNavigation(NavigationHandle* handle) {
   if (handle_ || handle->GetURL() != url_)
     return false;
   if (handled_navigation_)
     return false;
   return true;
 }
 
 }  // namespace content