Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: extensions/browser/management_policy.h

Issue 2310683002: Remove most ScopedVector usage from c/b/extensions. (Closed)
Patch Set: remove scoped_vector includes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/external_provider_interface.h ('k') | extensions/browser/management_policy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/management_policy.h
diff --git a/extensions/browser/management_policy.h b/extensions/browser/management_policy.h
index 584af58bed94dde499f84f2e3eecd265c05af81c..a9672b2bbd07f49e7274df77336a7be072e367f8 100644
--- a/extensions/browser/management_policy.h
+++ b/extensions/browser/management_policy.h
@@ -100,7 +100,8 @@ class ManagementPolicy {
void UnregisterProvider(Provider* provider);
// Like RegisterProvider(), but registers multiple providers instead.
- void RegisterProviders(std::vector<Provider*> providers);
+ void RegisterProviders(
+ const std::vector<std::unique_ptr<Provider>>& providers);
// Returns true if the user is permitted to install, load, and run the given
// extension. If not, |error| may be set to an appropriate message.
@@ -154,6 +155,8 @@ class ManagementPolicy {
const Extension* extension,
base::string16* error) const;
+ // This stores raw pointers to Provider.
+ // TODO(lazyboy): Consider making ManagementPolicy own these providers.
ProviderList providers_;
DISALLOW_COPY_AND_ASSIGN(ManagementPolicy);
« no previous file with comments | « extensions/browser/external_provider_interface.h ('k') | extensions/browser/management_policy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698