components/sync/device_info/device_info_tracker.h - Issue 2310683002: Remove most ScopedVector usage from c/b/extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/device_info/device_info_tracker.h

Issue 2310683002: Remove most ScopedVector usage from c/b/extensions. (Closed)

Patch Set: fix webstore_api Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/device_info/device_info_tracker.h

diff --git a/components/sync/device_info/device_info_tracker.h b/components/sync/device_info/device_info_tracker.h

index c3321417a096e9aa03534b73b7f913c2b6e41912..a7264e9b0d29eec2975dede6e116da6b06124b1c 100644

--- a/components/sync/device_info/device_info_tracker.h

+++ b/components/sync/device_info/device_info_tracker.h

@@ -32,7 +32,7 @@ class DeviceInfoTracker {

virtual std::unique_ptr<DeviceInfo> GetDeviceInfo(

const std::string& client_id) const = 0;

// Gets DeviceInfo for all synced devices (including the local one).

- virtual ScopedVector<DeviceInfo> GetAllDeviceInfo() const = 0;

+ virtual std::vector<std::unique_ptr<DeviceInfo>> GetAllDeviceInfo() const = 0;

// Registers an observer to be called on syncing any updated DeviceInfo.

virtual void AddObserver(Observer* observer) = 0;

// Unregisters an observer.