chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h - Issue 2310683002: Remove most ScopedVector usage from c/b/extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h

Issue 2310683002: Remove most ScopedVector usage from c/b/extensions. (Closed)

Patch Set: fix webstore_api Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc ('k') | chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc » ('j') | components/sync/device_info/device_info_sync_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h

diff --git a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h

index 8bc591b70ce2f80d4b7ab0f7f4f9d5b23f162af4..ba7a08023c7fec9e6cf66ab04bd0ad4529d4d771 100644

--- a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h

+++ b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h

@@ -9,7 +9,6 @@

#include "base/gtest_prod_util.h"

#include "base/macros.h"

-#include "base/memory/scoped_vector.h"

#include "base/scoped_observer.h"

#include "components/sync/device_info/device_info_tracker.h"

#include "extensions/browser/browser_context_keyed_api_factory.h"

@@ -91,7 +90,7 @@ class SignedInDevicesManager : public BrowserContextKeyedAPI,

void RemoveChangeObserverForExtension(const std::string& extension_id);

Profile* const profile_;

- ScopedVector<SignedInDevicesChangeObserver> change_observers_;

+ std::vector<std::unique_ptr<SignedInDevicesChangeObserver>> change_observers_;

// Listen to extension unloaded notification.

ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>