chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h - Issue 2310683002: Remove most ScopedVector usage from c/b/extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h

Issue 2310683002: Remove most ScopedVector usage from c/b/extensions. (Closed)

Patch Set: fix webstore_api Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/gcd_private/privet_v3_session.cc ('k') | chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.cc » ('j') | components/sync/device_info/device_info_sync_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h

diff --git a/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h b/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h

index 69a8dfabb86ffe9eafb54bf985e38044c8e9d01a..046ff752809d50995c8b4645a4a520ccf583ef9d 100644

--- a/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h

+++ b/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h

@@ -45,7 +45,7 @@ std::string GetGUIDFromPublicId(

// The dictionary would have the public id as the key and the

// device guid as the value.

void CreateMappingForUnmappedDevices(

- std::vector<sync_driver::DeviceInfo*>* device_info,

+ const std::vector<std::unique_ptr<sync_driver::DeviceInfo>>& device_info,

base::DictionaryValue* value);

// Gets the device info for a given client id. If the device is not found