Remove most ScopedVector usage from c/b/extensions.

extensions/browser/management_policy.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/management_policy.h"
 
 namespace extensions {
 
 namespace {
 
@@ skipping 43 matching lines @@
 }
 
 void ManagementPolicy::RegisterProvider(Provider* provider) {
   providers_.insert(provider);
 }
 
 void ManagementPolicy::UnregisterProvider(Provider* provider) {
   providers_.erase(provider);
 }
 
-void ManagementPolicy::RegisterProviders(std::vector<Provider*> providers) {
-  providers_.insert(providers.begin(), providers.end());
+void ManagementPolicy::RegisterProviders(
+    const std::vector<std::unique_ptr<Provider>>& providers) {
+  for (const std::unique_ptr<Provider>& provider : providers)
+    providers_.insert(provider.get());

[asargent_no_longer_on_chrome, 2016/09/06 22:12:40]

Hmm, this is a little unusual - when I see unique_ptr's as arguments, I usually
expect ownership to be transferred (that's typically what happens with
single-argument unique_ptr's not wrapped in a vector). 

Doesn't it seem a little unsafe that we just hold on to raw ptr's here? Could
ownership be transferred? Or could we use weak_ptr or RefCounted? At a minimum
we should probably have some comment about the lifetime expectations. 

[lazyboy, 2016/09/06 23:49:38]

Ya.
I think this is what ScopedVector was kind of hiding:
ScopedVector<T>::get() returns raw pointers: vector<T*>, that what
RegisterProviders is called with.
Think so. I don't see an easy way to transfer ownership as multiple classes are
adding to |providers_| in different ways. SupervisedUserService would be one
hard one to fix.
I've added TODO in the header file beside |providers_|.
Could

 }
 
 bool ManagementPolicy::UserMayLoad(const Extension* extension,
                                    base::string16* error) const {
   return ApplyToProviderList(
       &Provider::UserMayLoad, "Installation", true, extension, error);
 }
 
 bool ManagementPolicy::UserMayModifySettings(const Extension* extension,
                                              base::string16* error) const {
@@ skipping 48 matching lines @@
       DVLOG(1) << debug_operation_name << " of extension " << name
                << " (" << id << ")"
                << " prohibited by " << provider->GetDebugPolicyProviderName();
       return !normal_result;
     }
   }
   return normal_result;
 }
 
 }  // namespace extensions