Remove most ScopedVector usage from c/b/extensions.

chrome/browser/extensions/api/tab_capture/offscreen_tab.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/tab_capture/offscreen_tab.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "chrome/browser/extensions/api/tab_capture/tab_capture_registry.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/web_contents_sizer.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/process_manager.h"
 
 using content::WebContents;
 
@@ skipping 29 matching lines @@
   return FromWebContents(extension_web_contents);
 }
 
 OffscreenTab* OffscreenTabsOwner::OpenNewTab(
     const GURL& start_url,
     const gfx::Size& initial_size,
     const std::string& optional_presentation_id) {
   if (tabs_.size() >= kMaxOffscreenTabsPerExtension)
     return nullptr;  // Maximum number of offscreen tabs reached.
 
-  tabs_.push_back(new OffscreenTab(this));
+  // OffscreenTab cannot be created with MakeUnique<OffscreenTab> since the
+  // constructor is protected. So create it separately, and then move it to
+  // |tabs_| below.
+  std::unique_ptr<OffscreenTab> offscreen_tab(new OffscreenTab(this));
+  tabs_.push_back(std::move(offscreen_tab));
   tabs_.back()->Start(start_url, initial_size, optional_presentation_id);
-  return tabs_.back();
+  return tabs_.back().get();
 }
 
 void OffscreenTabsOwner::DestroyTab(OffscreenTab* tab) {
-  const auto it = std::find(tabs_.begin(), tabs_.end(), tab);
+  const auto it =
+      std::find_if(tabs_.begin(), tabs_.end(),
+                   [tab](const std::unique_ptr<OffscreenTab>& offscreen_tab) {
+                     return offscreen_tab.get() == tab;
+                   });
   if (it != tabs_.end())
     tabs_.erase(it);

[asargent_no_longer_on_chrome, 2016/09/06 22:12:40]

optional: a simpler way to write this method may be:

for (auto it : tabs_) {
  if (it->get() == tab) {
    tabs_.erase(it);
    break;
  }
}

[lazyboy, 2016/09/06 23:49:38]

Done.

 }
 
 OffscreenTab::OffscreenTab(OffscreenTabsOwner* owner)
     : owner_(owner),
       profile_(Profile::FromBrowserContext(
                    owner->extension_web_contents()->GetBrowserContext())
                ->CreateOffTheRecordProfile()),
       capture_poll_timer_(false, false),
       content_capture_was_detected_(false) {
   DCHECK(profile_);
@@ skipping 273 matching lines @@
 
   // Schedule the timer to check again in a second.
   capture_poll_timer_.Start(
       FROM_HERE,
       base::TimeDelta::FromSeconds(kPollIntervalInSeconds),
       base::Bind(&OffscreenTab::DieIfContentCaptureEnded,
                  base::Unretained(this)));
 }
 
 }  // namespace extensions