Remove most ScopedVector usage from c/b/extensions.

chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h"
 
 #include <memory>
 
-#include "base/memory/scoped_vector.h"
 #include "base/rand_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h"
 #include "chrome/browser/profiles/profile.h"
 #include "components/crx_file/id_util.h"
 #include "components/sync/device_info/device_info.h"
 
 using base::DictionaryValue;
 using base::Value;
@@ skipping 42 matching lines @@
 
   do {
     string_value = base::IntToString(rand_value);
     rand_value++;
   } while (mapping.Get(string_value, &out_value));
 
   return string_value;
 }
 
 void CreateMappingForUnmappedDevices(
-    std::vector<DeviceInfo*>* device_info,
+    const std::vector<std::unique_ptr<DeviceInfo>>& device_info,
     base::DictionaryValue* value) {
-  for (unsigned int i = 0; i < device_info->size(); ++i) {
-    DeviceInfo* device = (*device_info)[i];
+  for (const std::unique_ptr<DeviceInfo>& device : device_info) {
     std::string local_id = GetPublicIdFromGUID(*value,
                                                device->guid());
 
     // If the device does not have a local id, set one.
     if (local_id.empty()) {
-      local_id = GetRandomId(*value, device_info->size());
+      local_id = GetRandomId(*value, device_info.size());
       value->SetString(local_id, device->guid());
     }
     device->set_public_id(local_id);
   }
 }
 
 std::unique_ptr<DeviceInfo> GetDeviceInfoForClientId(
     const std::string& client_id,
     const std::string& extension_id,
     Profile* profile) {
   DCHECK(crx_file::id_util::IdIsValid(extension_id)) << extension_id
                                                      << " is not valid";
-  ScopedVector<DeviceInfo> devices = GetAllSignedInDevices(extension_id,
-                                                           profile);
-  for (ScopedVector<DeviceInfo>::iterator it = devices.begin();
-       it != devices.end();
-       ++it) {
+  std::vector<std::unique_ptr<DeviceInfo>> devices =
+      GetAllSignedInDevices(extension_id, profile);
+  for (std::vector<std::unique_ptr<DeviceInfo>>::iterator it = devices.begin();
+       it != devices.end(); ++it) {

[asargent_no_longer_on_chrome, 2016/09/06 22:12:40]

consider shortening this to:

for (auto it : devices) {

[lazyboy, 2016/09/06 23:49:38]

Done.

     if ((*it)->guid() == client_id) {
-      std::unique_ptr<DeviceInfo> device(*it);
-      devices.weak_erase(it);
+      std::unique_ptr<DeviceInfo> device = std::move(*it);
       return device;
     }
   }
   return std::unique_ptr<DeviceInfo>();
 }
 
 }  // namespace  extensions