Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: third_party/WebKit/Source/core/workers/ThreadedGlobalScopeProxy.h

Issue 2310673002: [worklets] Split up InProcessWorkerMessagingProxy into a base+worker class. (Closed)
Patch Set: ... Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/ThreadedGlobalScopeProxy.h
diff --git a/third_party/WebKit/Source/core/workers/WorkletGlobalScopeProxy.h b/third_party/WebKit/Source/core/workers/ThreadedGlobalScopeProxy.h
similarity index 32%
copy from third_party/WebKit/Source/core/workers/WorkletGlobalScopeProxy.h
copy to third_party/WebKit/Source/core/workers/ThreadedGlobalScopeProxy.h
index c584913310a54638aa24edbc7226acf563afc4d6..6b2f74d54d388867f1afb9220b0d378577a5ab9f 100644
--- a/third_party/WebKit/Source/core/workers/WorkletGlobalScopeProxy.h
+++ b/third_party/WebKit/Source/core/workers/ThreadedGlobalScopeProxy.h
@@ -2,27 +2,28 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef WorkletGlobalScopeProxy_h
-#define WorkletGlobalScopeProxy_h
+#ifndef ThreadedGlobalScopeProxy_h
+#define ThreadedGlobalScopeProxy_h
#include "core/CoreExport.h"
-#include "platform/weborigin/KURL.h"
-#include "wtf/text/WTFString.h"
+#include "wtf/Allocator.h"
namespace blink {
-class ScriptSourceCode;
-
-// A proxy to talk to the worklet global scope. The global scope may exist in
-// the main thread or on a different thread.
-class CORE_EXPORT WorkletGlobalScopeProxy {
+// The ThreadedGlobalScopeProxy is used to control the lifetime of the worker
+// or worklet's global scope.
+class CORE_EXPORT ThreadedGlobalScopeProxy {
ikilpatrick 2016/09/04 00:34:01 I wasn't sure what to do this with interface; we c
nhiroki 2016/09/06 07:07:08 I think this (InProcessWorkerObjectProxy) is not u
ikilpatrick 2016/09/06 18:59:49 Sounds good. I sent out a separate patch for this
+ USING_FAST_MALLOC(ThreadedGlobalScopeProxy);
public:
- virtual ~WorkletGlobalScopeProxy() { }
+ virtual ~ThreadedGlobalScopeProxy() { }
+
+ virtual void terminateGlobalScope() = 0;
+
+ virtual bool hasPendingActivity() const = 0;
- virtual void evaluateScript(const ScriptSourceCode&) = 0;
- virtual void terminateWorkletGlobalScope() = 0;
+ virtual void parentObjectDestroyed() = 0;
};
} // namespace blink
-#endif // WorkletGlobalScopeProxy_h
+#endif // ThreadedGlobalScopeProxy_h

Powered by Google App Engine
This is Rietveld 408576698