third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp - Issue 2310673002: [worklets] Split up InProcessWorkerMessagingProxy into a base+worker class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp

Issue 2310673002: [worklets] Split up InProcessWorkerMessagingProxy into a base+worker class. (Closed)

Patch Set: address comments. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/BUILD.gn ('k') | third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp

diff --git a/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp b/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp

index ac26ea6baaf55d65077d3f6827db816646624071..8af2960e6ebbb71d6a02d685b63f545b8bd3ffc4 100644

--- a/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp

+++ b/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp

@@ -30,7 +30,7 @@ InProcessWorkerBase::~InProcessWorkerBase()

DCHECK(isMainThread());

if (!m_contextProxy)

return;

- m_contextProxy->workerObjectDestroyed();

+ m_contextProxy->parentObjectDestroyed();

}

void InProcessWorkerBase::postMessage(ExecutionContext* context, PassRefPtr<SerializedScriptValue> message, const MessagePortArray& ports, ExceptionState& exceptionState)

@@ -69,7 +69,7 @@ bool InProcessWorkerBase::initialize(ExecutionContext* context, const String& ur

void InProcessWorkerBase::terminate()

{

if (m_contextProxy)

- m_contextProxy->terminateWorkerGlobalScope();

+ m_contextProxy->terminateGlobalScope();

}

void InProcessWorkerBase::stop()