third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js - Issue 2310633002: DevTools: Reduce color parsing by passing in Color to ColorSwatch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

Issue 2310633002: DevTools: Reduce color parsing by passing in Color to ColorSwatch (Closed)

Patch Set: Get color from model Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js » ('j') | third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

index c90c911645e8aaab1cf51d90f98d0d5188f91283..faf2c28d47bad68d81d9cd7e23ac88d148fc3c38 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

@@ -98,9 +98,11 @@ WebInspector.AppManifestView.prototype = {

this._startURLField.appendChild(WebInspector.linkifyResourceAsNode(/** @type {string} */(WebInspector.ParsedURL.completeURL(url, startURL)), undefined, undefined, undefined, undefined, startURL));

this._themeColorSwatch.classList.toggle("hidden", !stringProperty("theme_color"));

- this._themeColorSwatch.setColorText(stringProperty("theme_color") || "white");

+ var themeColor = WebInspector.Color.parse(stringProperty("theme_color") || "white") || WebInspector.Color.parse("white");

+ this._themeColorSwatch.setColor(/** @type {!WebInspector.Color} */ (themeColor));

this._backgroundColorSwatch.classList.toggle("hidden", !stringProperty("background_color"));

- this._backgroundColorSwatch.setColorText(stringProperty("background_color") || "white");

+ var backgroundColor = WebInspector.Color.parse(stringProperty("background_color") || "white") || WebInspector.Color.parse("white");

+ this._backgroundColorSwatch.setColor(/** @type {!WebInspector.Color} */ (backgroundColor));

this._orientationField.textContent = stringProperty("orientation");

this._displayField.textContent = stringProperty("display");