third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js - Issue 2310633002: DevTools: Reduce color parsing by passing in Color to ColorSwatch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 2310633002: DevTools: Reduce color parsing by passing in Color to ColorSwatch (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js » ('j') | third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

index ccb9c9db97d012019516e7c973800e4b14de05bd..d724e9e627df433d4f74e2a2af0cad521859c0bf 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

@@ -1955,13 +1955,13 @@ WebInspector.StylePropertyTreeElement.prototype = {

if (!this._editable()) {

var swatch = WebInspector.ColorSwatch.create();

- swatch.setColorText(text);

+ swatch.setColor(color);

return swatch;

}

var swatchPopoverHelper = this._parentPane._swatchPopoverHelper;

var swatch = WebInspector.ColorSwatch.create();

- swatch.setColorText(text);

+ swatch.setColor(color);

swatch.setFormat(WebInspector.Color.detectColorFormat(swatch.color()));

var swatchIcon = new WebInspector.ColorSwatchPopoverIcon(this, swatchPopoverHelper, swatch);