third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js - Issue 2310633002: DevTools: Reduce color parsing by passing in Color to ColorSwatch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js

Issue 2310633002: DevTools: Reduce color parsing by passing in Color to ColorSwatch (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js » ('j') | third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js b/third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js

index c5ab08aab504f4d3cd5db880bebaa8d7faee5277..13875c5dbc0913f40921c78a9a15cc7a48a52b31 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js

@@ -192,8 +192,10 @@ WebInspector.ColorSwatchPopoverIcon.prototype = {

_spectrumChanged: function(event)

{

- var colorString = /** @type {string} */ (event.data);

- this._swatch.setColorText(colorString);

+ var color = WebInspector.Color.parse(/** @type {string} */ (event.data));

+ if (!color)

+ return;

+ this._swatch.setColor(color);

this._treeElement.applyStyleText(this._treeElement.renderedPropertyText(), false);