DevTools: Reduce color parsing by passing in Color to ColorSwatch

third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 148 matching lines @@
             }
         }
     },
 
     /**
      * @param {string} text
      * @return {?WebInspector.ColorSwatch}
      */
     _createColorSwatch: function(text)
     {
-        if (!WebInspector.Color.parse(text))
+        var color = WebInspector.Color.parse(text);
+        if (!color)
             return null;
         var swatch = WebInspector.ColorSwatch.create();
-        swatch.setColorText(text);
+        swatch.setColor(color);
         swatch.iconElement().title = WebInspector.UIString("Open color picker.");
         swatch.iconElement().addEventListener("click", this._swatchIconClicked.bind(this, swatch), false);
         swatch.hideText(true);
         return swatch;
     },
 
     /**
      * @param {string} text
      * @return {?WebInspector.BezierSwatch}
      */
@@ skipping 50 matching lines @@
     _spectrumResized: function(event)
     {
         this._swatchPopoverHelper.reposition();
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _spectrumChanged: function(event)
     {
         var colorString = /** @type {string} */ (event.data);

[lushnikov, 2016/09/09 00:16:42]

spectrm should've fired a Color objects here, but that should be a separate
patch...

-        this._currentSwatch.setColorText(colorString);
+        var color = WebInspector.Color.parse(colorString);
+        if (!color)
+            return;
+        this._currentSwatch.setColor(color);
         this._changeSwatchText(colorString);
     },
 
     /**
      * @param {!WebInspector.BezierSwatch} swatch
      */
     _showBezierEditor: function(swatch)
     {
         if (!this._bezierEditor) {
             this._bezierEditor = new WebInspector.BezierEditor();
@@ skipping 126 matching lines @@
                 else
                     return null;
             }
             tokenPosition = token.startColumn - 1;
         }
         return null;
     },
 
     __proto__: WebInspector.UISourceCodeFrame.prototype
 }