DevTools: Reduce color parsing by passing in Color to ColorSwatch

third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 1937 matching lines @@
      */
     _processColor: function(text)
     {
         // We can be called with valid non-color values of |text| (like 'none' from border style)
         var color = WebInspector.Color.parse(text);
         if (!color)
             return createTextNode(text);
 
         if (!this._editable()) {
             var swatch = WebInspector.ColorSwatch.create();
-            swatch.setColorText(text);
+            swatch.setColor(color);
             return swatch;
         }
 
         var swatchPopoverHelper = this._parentPane._swatchPopoverHelper;
         var swatch = WebInspector.ColorSwatch.create();
-        swatch.setColorText(text);
+        swatch.setColor(color);
         swatch.setFormat(WebInspector.Color.detectColorFormat(swatch.color()));
         var swatchIcon = new WebInspector.ColorSwatchPopoverIcon(this, swatchPopoverHelper, swatch);
 
         /**
          * @param {?Array<string>} backgroundColors
          */
         function computedCallback(backgroundColors)
         {
             // TODO(aboxhall): distinguish between !backgroundColors (no text) and
             // !backgroundColors.length (no computed bg color)
@@ skipping 66 matching lines @@
             return createTextNode(propertyValue);
         var container = createDocumentFragment();
         var swatchPopoverHelper = this._parentPane._swatchPopoverHelper;
         for (var i = 0; i < shadows.length; i++) {
             if (i !== 0)
                 container.appendChild(createTextNode(", ")); // Add back commas and spaces between each shadow.
             // TODO(flandy): editing the property value should use the original value with all spaces.
             var cssShadowSwatch = WebInspector.CSSShadowSwatch.create();
             cssShadowSwatch.setCSSShadow(shadows[i]);
             new WebInspector.ShadowSwatchPopoverHelper(this, swatchPopoverHelper, cssShadowSwatch);
-            if (cssShadowSwatch.colorSwatch())
-                var colorSwatchIcon = new WebInspector.ColorSwatchPopoverIcon(this, swatchPopoverHelper, cssShadowSwatch.colorSwatch());
+            var colorSwatch = cssShadowSwatch.colorSwatch();
+            if (colorSwatch)
+                new WebInspector.ColorSwatchPopoverIcon(this, swatchPopoverHelper, colorSwatch);
             container.appendChild(cssShadowSwatch);
         }
         return container;
     },
 
     _updateState: function()
     {
         if (!this.listItemElement)
             return;
 
@@ skipping 1089 matching lines @@
 
     /**
      * @override
      * @return {!WebInspector.ToolbarItem}
      */
     item: function()
     {
         return this._button;
     }
 }