DevTools: Reduce color parsing by passing in Color to ColorSwatch

third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 123 matching lines @@
         /**
          * @this {WebInspector.CSSSourceFrame}
          */
         function putColorSwatchesInline()
         {
             this._clearBookmarks(startLine, endLine);
 
             for (var i = 0; i < colorPositions.length; i++) {
                 var colorPosition = colorPositions[i];
                 var swatch = WebInspector.ColorSwatch.create();
-                swatch.setColorText(colorPosition.color.asString(WebInspector.Color.Format.Original));
+                swatch.setColor(colorPosition.color);
                 swatch.iconElement().title = WebInspector.UIString("Open color picker.");
                 swatch.hideText(true);
                 var bookmark = this.textEditor.addBookmark(colorPosition.textRange.startLine, colorPosition.textRange.startColumn, swatch, WebInspector.CSSSourceFrame.SwatchBookmark);
                 swatch.iconElement().addEventListener("click", this._showSpectrum.bind(this, swatch, bookmark), true);
             }
         }
     },
 
     /**
      * @param {number} startLine
@@ skipping 38 matching lines @@
     _spectrumResized: function(event)
     {
         this._swatchPopoverHelper.reposition();
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _spectrumChanged: function(event)
     {
+        var colorString = /** @type {string} */ (event.data);
+        var color = WebInspector.Color.parse(colorString)

[dgozman, 2016/09/02 22:08:01]

style: missing semicolon

[flandy, 2016/09/02 23:09:18]

Sorry, done.

+        if (!color)
+            return;
+        this._currentSwatch.setColor(color);
         this._muteColorProcessing = true;
         this._hadSpectrumChange = true;
-        var colorString = /** @type {string} */ (event.data);
-        this._currentSwatch.setColorText(colorString);
         this._textEditor.editRange(this._currentColorTextRange, colorString, "*color-text-changed");
         this._currentColorTextRange.endColumn = this._currentColorTextRange.startColumn + colorString.length;
     },
 
     /**
      * @param {boolean} commitEdit
      */
     _spectrumHidden: function(commitEdit)
     {
         this._muteColorProcessing = false;
@@ skipping 109 matching lines @@
  * @param {!WebInspector.Color} color
  * @param {number} lineNumber
  * @param {number} startColumn
  * @param {number} textLength
  */
 WebInspector.CSSSourceFrame.ColorPosition = function(color, lineNumber, startColumn, textLength)
 {
     this.color = color;
     this.textRange = new WebInspector.TextRange(lineNumber, startColumn, lineNumber, startColumn + textLength);
 }