DevTools: Reduce color parsing by passing in Color to ColorSwatch

third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  * @implements {WebInspector.TargetManager.Observer}
  */
 WebInspector.AppManifestView = function()
@@ skipping 79 matching lines @@
             data = "{}";
 
         var parsedManifest = JSON.parse(data);
         this._nameField.textContent = stringProperty("name");
         this._shortNameField.textContent = stringProperty("short_name");
         this._startURLField.removeChildren();
         var startURL = stringProperty("start_url");
         if (startURL)
             this._startURLField.appendChild(WebInspector.linkifyResourceAsNode(/** @type {string} */(WebInspector.ParsedURL.completeURL(url, startURL)), undefined, undefined, undefined, undefined, startURL));
 
-        this._themeColorSwatch.classList.toggle("hidden", !stringProperty("theme_color"));
-        this._themeColorSwatch.setColorText(stringProperty("theme_color") || "white");
-        this._backgroundColorSwatch.classList.toggle("hidden", !stringProperty("background_color"));
-        this._backgroundColorSwatch.setColorText(stringProperty("background_color") || "white");
+        if (stringProperty("theme_color")) {
+            this._themeColorSwatch.classList.remove("hidden");
+            var themeColor = WebInspector.Color.parse(stringProperty("theme_color")) || WebInspector.Color.parse("white");

[dgozman, 2016/09/02 22:08:01]

This is a semantic change. Leave it as parse(stringPorperty(...) || "white").

[flandy, 2016/09/02 23:09:18]

We need the extra || WebInspector.Color.parse("white") because if
stringProperty(...) is a valid string but not a valid color, there is no
guarantee that a Color was returned instead of null. 

+            this._themeColorSwatch.setColor(/** @type {!WebInspector.Color} */ (themeColor));
+        } else {
+            this._themeColorSwatch.classList.add("hidden");
+        }
+
+        if (stringProperty("background_color")) {
+            this._backgroundColorSwatch.classList.remove("hidden");
+            var backgroundColor = WebInspector.Color.parse(stringProperty("background_color")) || WebInspector.Color.parse("white");

[dgozman, 2016/09/02 22:08:01]

ditto

+            this._backgroundColorSwatch.setColor(/** @type {!WebInspector.Color} */ (backgroundColor));
+        } else {
+            this._backgroundColorSwatch.classList.add("hidden");
+        }
 
         this._orientationField.textContent = stringProperty("orientation");
         this._displayField.textContent = stringProperty("display");
 
         var icons = parsedManifest["icons"] || [];
         this._iconsSection.clearContent();
         for (var icon of icons) {
             var title = (icon["sizes"] || "") + "\n" + (icon["type"] || "");
             var field = this._iconsSection.appendField(title);
             var imageElement = field.createChild("img");
@@ skipping 19 matching lines @@
     {
         var target = WebInspector.targetManager.mainTarget();
         if (target && target.hasBrowserCapability()) {
             target.pageAgent().requestAppBanner();
             WebInspector.console.show();
         }
     },
 
     __proto__: WebInspector.VBox.prototype
 }