Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2310613002: Inline GPU and opus GYP files into GN build. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline GPU and opus GYP files into GN build. Remove obsolete GYP files. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=dpranke@chromium.org Committed: https://crrev.com/46134cb939483ac9e046f560664528e3806a0586 Cr-Commit-Position: refs/heads/master@{#416398}

Patch Set 1 #

Patch Set 2 : remove more #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1000 lines, -4607 lines) Patch
M .gn View 1 2 3 chunks +3 lines, -17 lines 0 comments Download
D gpu/command_buffer/command_buffer.gyp View 1 1 chunk +0 lines, -59 lines 0 comments Download
D gpu/command_buffer/command_buffer.gypi View 1 1 chunk +0 lines, -24 lines 0 comments Download
D gpu/command_buffer/command_buffer_nacl.gyp View 1 1 chunk +0 lines, -39 lines 0 comments Download
D gpu/command_buffer_client.gypi View 1 1 chunk +0 lines, -32 lines 0 comments Download
D gpu/command_buffer_common.gypi View 1 1 chunk +0 lines, -42 lines 0 comments Download
D gpu/command_buffer_service.gypi View 1 1 chunk +0 lines, -161 lines 0 comments Download
D gpu/command_buffer_traits.gypi View 1 1 chunk +0 lines, -44 lines 0 comments Download
D gpu/gles2_cmd_helper.gypi View 1 1 chunk +0 lines, -12 lines 0 comments Download
M gpu/gles2_conform_support/BUILD.gn View 2 chunks +296 lines, -13 lines 0 comments Download
D gpu/gles2_conform_support/gles2_conform.gypi View 1 chunk +0 lines, -315 lines 0 comments Download
D gpu/gles2_conform_support/gles2_conform_support.gyp View 1 1 chunk +0 lines, -123 lines 0 comments Download
D gpu/gles2_conform_support/gles2_conform_test.gyp View 1 1 chunk +0 lines, -270 lines 0 comments Download
D gpu/gpu.gyp View 1 1 chunk +0 lines, -1202 lines 0 comments Download
D gpu/gpu_common.gypi View 1 1 chunk +0 lines, -50 lines 0 comments Download
D gpu/gpu_config.gypi View 1 1 chunk +0 lines, -86 lines 0 comments Download
D gpu/gpu_ipc_client.gypi View 1 1 chunk +0 lines, -72 lines 0 comments Download
D gpu/gpu_ipc_common.gypi View 1 1 chunk +0 lines, -54 lines 0 comments Download
D gpu/gpu_ipc_service.gypi View 1 1 chunk +0 lines, -99 lines 0 comments Download
D gpu/gpu_nacl.gyp View 1 1 chunk +0 lines, -132 lines 0 comments Download
M gpu/khronos_glcts_support/BUILD.gn View 21 chunks +472 lines, -59 lines 0 comments Download
D gpu/khronos_glcts_support/khronos_glcts.gypi View 1 chunk +0 lines, -490 lines 0 comments Download
D gpu/khronos_glcts_support/khronos_glcts_cts.gyp View 1 1 chunk +0 lines, -105 lines 0 comments Download
D gpu/khronos_glcts_support/khronos_glcts_defaults.gypi View 1 1 chunk +0 lines, -34 lines 0 comments Download
D gpu/khronos_glcts_support/khronos_glcts_framework.gyp View 1 1 chunk +0 lines, -248 lines 0 comments Download
D gpu/khronos_glcts_support/khronos_glcts_gtf.gyp View 1 1 chunk +0 lines, -67 lines 0 comments Download
D gpu/khronos_glcts_support/khronos_glcts_test.gyp View 1 1 chunk +0 lines, -102 lines 0 comments Download
D gpu/skia_bindings/skia_bindings.gyp View 1 1 chunk +0 lines, -26 lines 0 comments Download
D gpu/tools/tools.gyp View 1 1 chunk +0 lines, -40 lines 0 comments Download
M third_party/opus/BUILD.gn View 2 chunks +229 lines, -7 lines 0 comments Download
D third_party/opus/opus.gyp View 1 chunk +0 lines, -246 lines 0 comments Download
D third_party/opus/opus_nacl.gyp View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/opus/opus_srcs.gypi View 1 chunk +0 lines, -237 lines 0 comments Download
D third_party/opus/opus_srcs_arm.gypi View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/opus/opus_srcs_rtcd.gypi View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
brettw
remove more
4 years, 3 months ago (2016-09-02 20:27:29 UTC) #2
brettw
4 years, 3 months ago (2016-09-02 20:27:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310613002/20001
4 years, 3 months ago (2016-09-02 21:22:35 UTC) #10
brettw
merge
4 years, 3 months ago (2016-09-02 22:41:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310613002/40001
4 years, 3 months ago (2016-09-02 22:41:39 UTC) #13
commit-bot: I haz the power
Exceeded global retry quota
4 years, 3 months ago (2016-09-02 23:22:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310613002/40001
4 years, 3 months ago (2016-09-02 23:34:08 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 23:53:40 UTC) #19
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/46134cb939483ac9e046f560664528e3806a0586 Cr-Commit-Position: refs/heads/master@{#416398}
4 years, 3 months ago (2016-09-02 23:55:39 UTC) #21
Dirk Pranke
4 years, 3 months ago (2016-09-06 00:37:23 UTC) #22
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698