Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 23106004: [Android] Removes run_* scripts, moves run_update_verificaiton (Closed)

Created:
7 years, 4 months ago by gkanwar1
Modified:
7 years, 4 months ago
Reviewers:
craigdh, frankf, Torne
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Removes run_* scripts, moves run_update_verificaiton NOTRY=True BUG=223650 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217588

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes all_android.gyp comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -229 lines) Patch
M build/all_android.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download
D build/android/run_browser_tests.py View 1 chunk +0 lines, -23 lines 0 comments Download
D build/android/run_instrumentation_tests.py View 1 chunk +0 lines, -23 lines 0 comments Download
D build/android/run_tests.py View 1 chunk +0 lines, -23 lines 0 comments Download
D build/android/run_uiautomator_tests.py View 1 chunk +0 lines, -24 lines 0 comments Download
D build/android/run_update_verification.py View 1 chunk +0 lines, -135 lines 0 comments Download
A + update_verification.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
gkanwar1
ptal
7 years, 4 months ago (2013-08-13 18:58:30 UTC) #1
frankf
lgtm after fix https://codereview.chromium.org/23106004/diff/1/build/all_android.gyp File build/all_android.gyp (right): https://codereview.chromium.org/23106004/diff/1/build/all_android.gyp#newcode43 build/all_android.gyp:43: # please also add it to ...
7 years, 4 months ago (2013-08-13 19:02:06 UTC) #2
gkanwar1
https://codereview.chromium.org/23106004/diff/1/build/all_android.gyp File build/all_android.gyp (right): https://codereview.chromium.org/23106004/diff/1/build/all_android.gyp#newcode43 build/all_android.gyp:43: # please also add it to build/android/pylib/gtest/setup.py, else the ...
7 years, 4 months ago (2013-08-13 19:03:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@chromium.org/23106004/7001
7 years, 4 months ago (2013-08-14 18:06:27 UTC) #4
commit-bot: I haz the power
Change committed as 217588
7 years, 4 months ago (2013-08-14 18:09:41 UTC) #5
Torne
Did you really mean to move update_verification.py to the root of the project with this ...
7 years, 4 months ago (2013-08-16 12:04:11 UTC) #6
gkanwar1
On 2013/08/16 12:04:11, Torne wrote: > Did you really mean to move update_verification.py to the ...
7 years, 4 months ago (2013-08-16 15:57:19 UTC) #7
gkanwar1
On 2013/08/16 15:57:19, gkanwar1 wrote: > On 2013/08/16 12:04:11, Torne wrote: > > Did you ...
7 years, 4 months ago (2013-08-16 16:49:56 UTC) #8
no sievers
Can you please update http://www.chromium.org/developers/testing/android-tests on how to run tests?
7 years, 4 months ago (2013-08-22 21:13:17 UTC) #9
frankf
On 2013/08/22 21:13:17, sievers wrote: > Can you please update http://www.chromium.org/developers/testing/android-tests > on how to ...
7 years, 4 months ago (2013-08-22 21:16:43 UTC) #10
gkanwar1
7 years, 4 months ago (2013-08-23 00:15:47 UTC) #11
Message was sent while issue was closed.
On 2013/08/22 21:16:43, frankf wrote:
> On 2013/08/22 21:13:17, sievers wrote:
> > Can you please update
http://www.chromium.org/developers/testing/android-tests
> > on how to run tests?
> 
> This is documented here:
> https://code.google.com/p/chromium/wiki/AndroidTestInstructions

I updated the chromium.org page to mention the correct scripts. I also added a
section on running tests, and pointed it at the Google Code wiki page.

Powered by Google App Engine
This is Rietveld 408576698