Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 2310593002: Remove call to IsRunningSequenceOnCurrentThread() from api_resource_manager.h. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, gab
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove call to IsRunningSequenceOnCurrentThread() from api_resource_manager.h. SequencedWorkerPool is being migrated to base/task_scheduler and there is no equivalent to IsRunningSequenceOnCurrentThread() in base/task_scheduler. We believe that always doing work asynchronously is cleaner than using this pattern: if (pool->IsRunningSequencedOnCurrentThread(token)) DoSequencedWork(); else pool->PostSequencedWorkerTask(token, FROM_HERE, Bind(&DoSequencedWork)); Developers should us SequenceChecker to verify that tasks run sequentially. Unlike SequencedWorkerPool::IsRunningSequenceOnCurrentThread(), SequenceChecker works everywhere in Chrome (MessageLoop, SequencedWorkerPool, base/task_scheduler...). BUG=622400 Committed: https://crrev.com/62f47315fa2bae98943888334e2787ce308659e8 Cr-Commit-Position: refs/heads/master@{#416679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -32 lines) Patch
M extensions/browser/api/api_resource_manager.h View 12 chunks +11 lines, -32 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-06 14:03:30 UTC) #6
Reilly Grant (use Gerrit)
lgtm
4 years, 3 months ago (2016-09-06 17:35:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310593002/1
4 years, 3 months ago (2016-09-06 17:45:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 18:37:18 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 18:39:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62f47315fa2bae98943888334e2787ce308659e8
Cr-Commit-Position: refs/heads/master@{#416679}

Powered by Google App Engine
This is Rietveld 408576698