Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 2310573002: dart2js: Pass type information to constructor rather than add later. (Closed)
Patch Set: remove debug print Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/codegen.dart
diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart
index abd0314aa45d4ca41cd3399deef69fe4e94f619a..52726ef5e3717a66c0f45e335b5ea854738ada27 100644
--- a/pkg/compiler/lib/src/ssa/codegen.dart
+++ b/pkg/compiler/lib/src/ssa/codegen.dart
@@ -1943,10 +1943,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
if (node.element.isClosure) {
registry.registerInstantiatedClass(node.element);
}
- if (node.instantiatedTypes == null) {
- return;
- }
- node.instantiatedTypes.forEach((type) {
+ node.instantiatedTypes?.forEach((type) {
Siggi Cherem (dart-lang) 2016/09/07 17:49:38 nit: while we are at it, use a tear-off instead of
sra1 2016/09/07 18:16:06 Done.
registry.registerInstantiation(type);
});
}

Powered by Google App Engine
This is Rietveld 408576698