Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2310543002: Limits only 16 new QUIC connections can be opened per epoll event. (Closed)

Created:
4 years, 3 months ago by Victor Vasiliev
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Limits only 16 new QUIC connections can be opened per epoll event. Change QuicBufferedPacketStore to buffer early arrived packets as well as CHLO and use this to buffer CHLOs whose connection's creation is postponed. Protected by --quic_limit_num_new_sessions_per_epoll_loop. Merge internal change: 131102299 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Limits only 16 new QUIC connections can be opened per epoll event. #

Patch Set 3 : Disable flags and see what happens #

Patch Set 4 : Limits only 16 new QUIC connections can be opened per epoll event. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+753 lines, -66 lines) Patch
M net/quic/core/quic_buffered_packet_store.h View 4 chunks +32 lines, -5 lines 0 comments Download
M net/quic/core/quic_buffered_packet_store.cc View 8 chunks +76 lines, -13 lines 0 comments Download
M net/quic/core/quic_buffered_packet_store_test.cc View 1 2 3 9 chunks +191 lines, -26 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 3 chunks +15 lines, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 6 chunks +58 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 2 3 7 chunks +231 lines, -19 lines 0 comments Download
M net/tools/quic/quic_server.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_test.cc View 1 2 3 2 chunks +115 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (16 generated)
Victor Vasiliev
4 years, 3 months ago (2016-09-02 19:28:53 UTC) #1
Ryan Hamilton
4 years, 3 months ago (2016-09-02 19:33:50 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698