Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: BUILD.gn

Issue 2310513002: Use -fno-delete-null-pointer-checks with gcc builds (Closed)
Patch Set: address nits and add GN config as well Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | gypfiles/toolchain.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/arm.gni") 6 import("//build/config/arm.gni")
7 import("//build/config/dcheck_always_on.gni") 7 import("//build/config/dcheck_always_on.gni")
8 import("//build/config/mips.gni") 8 import("//build/config/mips.gni")
9 import("//build/config/sanitizers/sanitizers.gni") 9 import("//build/config/sanitizers/sanitizers.gni")
10 10
(...skipping 304 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 if (is_win) { 315 if (is_win) {
316 # Increase the initial stack size. The default is 1MB, this is 2MB. This 316 # Increase the initial stack size. The default is 1MB, this is 2MB. This
317 # applies only to executables and shared libraries produced by V8 since 317 # applies only to executables and shared libraries produced by V8 since
318 # ldflags are not pushed to dependants. 318 # ldflags are not pushed to dependants.
319 ldflags += [ "/STACK:2097152" ] 319 ldflags += [ "/STACK:2097152" ]
320 } 320 }
321 } 321 }
322 if (is_android && v8_android_log_stdout) { 322 if (is_android && v8_android_log_stdout) {
323 defines += [ "V8_ANDROID_LOG_STDOUT" ] 323 defines += [ "V8_ANDROID_LOG_STDOUT" ]
324 } 324 }
325 if (!is_win && !is_clang) {
326 # GCC 6+ can optimize away pointer comparisons to null. This is
327 # problematic as V8 encodes Values through tagged pointers and comparisons
328 # with 0 are actually necessary in many cases. As a temporary Workaround
329 # we disable this optimization. See: https://crbug.com/v8/3782
330 cflags += [ "-fno-delete-null-pointer-checks" ]
331 }
325 332
326 # TODO(jochen): Support v8_enable_prof on Windows. 333 # TODO(jochen): Support v8_enable_prof on Windows.
327 # TODO(jochen): Add support for compiling with simulators. 334 # TODO(jochen): Add support for compiling with simulators.
328 335
329 if (is_debug) { 336 if (is_debug) {
330 if (is_linux && v8_enable_backtrace) { 337 if (is_linux && v8_enable_backtrace) {
331 ldflags += [ "-rdynamic" ] 338 ldflags += [ "-rdynamic" ]
332 } 339 }
333 340
334 # TODO(jochen): Add support for different debug optimization levels. 341 # TODO(jochen): Add support for different debug optimization levels.
(...skipping 2274 matching lines...) Expand 10 before | Expand all | Expand 10 after
2609 2616
2610 deps = [ 2617 deps = [
2611 ":fuzzer_support", 2618 ":fuzzer_support",
2612 ] 2619 ]
2613 2620
2614 configs = [ ":internal_config" ] 2621 configs = [ ":internal_config" ]
2615 } 2622 }
2616 2623
2617 v8_fuzzer("wasm_code_fuzzer") { 2624 v8_fuzzer("wasm_code_fuzzer") {
2618 } 2625 }
OLDNEW
« no previous file with comments | « no previous file | gypfiles/toolchain.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698