Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2310483002: Revert of Fix DCHECK when track status changes in non-playing state (Closed)

Created:
4 years, 3 months ago by servolk
Modified:
4 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix DCHECK when track status changes in non-playing state (patchset #3 id:40001 of https://codereview.chromium.org/2269313002/ ) Reason for revert: The new test is crashing on Mac Original issue's description: > Fix DCHECK when track status changes in non-playing state > > We are only accessing shared_state_.renderer in kPlaying state. > > BUG=640362 > > Committed: https://crrev.com/5f450aa795c85f615ccaed457f3114c487df7ac4 > Cr-Commit-Position: refs/heads/master@{#416131} TBR=avayvod@chromium.org,chcunningham@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=640362 Committed: https://crrev.com/ee58ec4c8b347db61fcd346ca293c6893cc1ec87 Cr-Commit-Position: refs/heads/master@{#416309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -67 lines) Patch
M media/base/pipeline_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/renderers/renderer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/test/pipeline_integration_test.cc View 4 chunks +2 lines, -64 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
servolk
Created Revert of Fix DCHECK when track status changes in non-playing state
4 years, 3 months ago (2016-09-02 18:23:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310483002/1
4 years, 3 months ago (2016-09-02 18:23:46 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-02 18:23:47 UTC) #5
servolk
4 years, 3 months ago (2016-09-02 18:27:39 UTC) #8
chcunningham
lgtm
4 years, 3 months ago (2016-09-02 18:54:40 UTC) #13
servolk
On 2016/09/02 18:54:40, chcunningham wrote: > lgtm thanks!
4 years, 3 months ago (2016-09-02 18:54:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310483002/1
4 years, 3 months ago (2016-09-02 18:55:32 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 18:57:09 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 18:58:54 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee58ec4c8b347db61fcd346ca293c6893cc1ec87
Cr-Commit-Position: refs/heads/master@{#416309}

Powered by Google App Engine
This is Rietveld 408576698