Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Issue 2310413002: Change /bin/sh to /bin/bash in run_compiler to see if fixes bot issues (Closed)

Created:
4 years, 3 months ago by Dan Beam
Modified:
4 years, 3 months ago
Reviewers:
iannucci
CC:
chromium-reviews, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, vitalyp+closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change /bin/sh to /bin/bash in run_compiler to see if fixes bot issues TBR=iannucci@chromium.org BUG=644563 NO_DEPENDENCY_CHECKS=true NOTRY=true Committed: https://crrev.com/64cc1c02aecef3a718ec9f8b54b0376e07cb6cb1 Cr-Commit-Position: refs/heads/master@{#416841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/closure_compiler/run_compiler View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
Dan Beam
4 years, 3 months ago (2016-09-07 03:58:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310413002/1
4 years, 3 months ago (2016-09-07 03:59:26 UTC) #5
iannucci
lgtm
4 years, 3 months ago (2016-09-07 04:00:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 04:03:05 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 04:04:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64cc1c02aecef3a718ec9f8b54b0376e07cb6cb1
Cr-Commit-Position: refs/heads/master@{#416841}

Powered by Google App Engine
This is Rietveld 408576698