Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: components/sessions/core/serialized_navigation_entry.h

Issue 2310363002: Persist offline page info in a navigation entry if needed (Closed)
Patch Set: Address feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SESSIONS_CORE_SERIALIZED_NAVIGATION_ENTRY_H_ 5 #ifndef COMPONENTS_SESSIONS_CORE_SERIALIZED_NAVIGATION_ENTRY_H_
6 #define COMPONENTS_SESSIONS_CORE_SERIALIZED_NAVIGATION_ENTRY_H_ 6 #define COMPONENTS_SESSIONS_CORE_SERIALIZED_NAVIGATION_ENTRY_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 } 115 }
116 116
117 std::set<std::string> content_pack_categories() const { 117 std::set<std::string> content_pack_categories() const {
118 return content_pack_categories_; 118 return content_pack_categories_;
119 } 119 }
120 void set_content_pack_categories( 120 void set_content_pack_categories(
121 const std::set<std::string>& content_pack_categories) { 121 const std::set<std::string>& content_pack_categories) {
122 content_pack_categories_ = content_pack_categories; 122 content_pack_categories_ = content_pack_categories;
123 } 123 }
124 const std::vector<GURL>& redirect_chain() const { return redirect_chain_; } 124 const std::vector<GURL>& redirect_chain() const { return redirect_chain_; }
125 const std::string& offline_page_info() const { return offline_page_info_; }
sky 2016/09/12 15:04:22 This needs better documentation. What is offline_p
jianli 2016/09/12 21:17:46 Done.
125 126
126 private: 127 private:
127 friend class ContentSerializedNavigationBuilder; 128 friend class ContentSerializedNavigationBuilder;
128 friend class ContentSerializedNavigationDriver; 129 friend class ContentSerializedNavigationDriver;
129 friend class SerializedNavigationEntryTestHelper; 130 friend class SerializedNavigationEntryTestHelper;
130 friend class IOSSerializedNavigationBuilder; 131 friend class IOSSerializedNavigationBuilder;
131 friend class IOSSerializedNavigationDriver; 132 friend class IOSSerializedNavigationDriver;
132 133
133 // Index in the NavigationController. 134 // Index in the NavigationController.
134 int index_; 135 int index_;
135 136
136 // Member variables corresponding to NavigationEntry fields. 137 // Member variables corresponding to NavigationEntry fields.
137 int unique_id_; 138 int unique_id_;
138 GURL referrer_url_; 139 GURL referrer_url_;
139 int referrer_policy_; 140 int referrer_policy_;
140 GURL virtual_url_; 141 GURL virtual_url_;
141 base::string16 title_; 142 base::string16 title_;
142 std::string encoded_page_state_; 143 std::string encoded_page_state_;
143 ui::PageTransition transition_type_; 144 ui::PageTransition transition_type_;
144 bool has_post_data_; 145 bool has_post_data_;
145 int64_t post_id_; 146 int64_t post_id_;
146 GURL original_request_url_; 147 GURL original_request_url_;
147 bool is_overriding_user_agent_; 148 bool is_overriding_user_agent_;
148 base::Time timestamp_; 149 base::Time timestamp_;
149 base::string16 search_terms_; 150 base::string16 search_terms_;
150 GURL favicon_url_; 151 GURL favicon_url_;
151 int http_status_code_; 152 int http_status_code_;
152 bool is_restored_; // Not persisted. 153 bool is_restored_; // Not persisted.
153 std::vector<GURL> redirect_chain_; // Not persisted. 154 std::vector<GURL> redirect_chain_; // Not persisted.
155 std::string offline_page_info_; // Not synced.
154 156
155 // Additional information. 157 // Additional information.
156 BlockedState blocked_state_; 158 BlockedState blocked_state_;
157 PasswordState password_state_; 159 PasswordState password_state_;
158 std::set<std::string> content_pack_categories_; 160 std::set<std::string> content_pack_categories_;
159 }; 161 };
160 162
161 } // namespace sessions 163 } // namespace sessions
162 164
163 #endif // COMPONENTS_SESSIONS_CORE_SERIALIZED_NAVIGATION_ENTRY_H_ 165 #endif // COMPONENTS_SESSIONS_CORE_SERIALIZED_NAVIGATION_ENTRY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698