Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 2310343002: Defer suspend events on Android when audio is active. (Closed)

Created:
4 years, 3 months ago by DaleCurtis
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, creis+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Defer suspend events on Android when audio is active. Suspend is killing the network connection powering audio playback for background audio cases. We should not suspend when there is an active playback going on. Probably we should also change the HasActiveAudio() logic on Android to include if there is an active media session -- as otherwise the user will not be able to resume playback from the media session. BUG=644515 TEST=background audio continues to work.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -1 line) Patch
M base/power_monitor/power_monitor.h View 3 chunks +13 lines, -0 lines 0 comments Download
M base/power_monitor/power_monitor.cc View 2 chunks +29 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/url_request/url_request_job.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698