Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 231033002: Remove unused AudioParams in PannerNode. (Closed)

Created:
6 years, 8 months ago by KhNo
Modified:
6 years, 8 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unused AudioParams in PannerNode. m_distanceGain and m_coneGain are not used internally in panner node. Remove useless valuables. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M Source/modules/webaudio/PannerNode.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/modules/webaudio/PannerNode.cpp View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
KhNo
Please review this patch. :)
6 years, 8 months ago (2014-04-09 15:32:17 UTC) #1
Raymond Toy
On 2014/04/09 15:32:17, KhNo wrote: > Please review this patch. :) Looks ok, but aren't ...
6 years, 8 months ago (2014-04-09 16:35:37 UTC) #2
KhNo
On 2014/04/09 16:35:37, Raymond Toy wrote: > On 2014/04/09 15:32:17, KhNo wrote: > > Please ...
6 years, 8 months ago (2014-04-09 17:33:36 UTC) #3
Raymond Toy
On 2014/04/09 17:33:36, KhNo wrote: > On 2014/04/09 16:35:37, Raymond Toy wrote: > > On ...
6 years, 8 months ago (2014-04-09 17:38:51 UTC) #4
KhNo
On 2014/04/09 17:38:51, Raymond Toy wrote: > On 2014/04/09 17:33:36, KhNo wrote: > > On ...
6 years, 8 months ago (2014-04-09 17:46:38 UTC) #5
Raymond Toy
lgtm
6 years, 8 months ago (2014-04-09 19:48:52 UTC) #6
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 8 months ago (2014-04-10 00:33:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/231033002/1
6 years, 8 months ago (2014-04-10 00:33:49 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 01:41:24 UTC) #9
Message was sent while issue was closed.
Change committed as 171214

Powered by Google App Engine
This is Rietveld 408576698