Moving It2Me confirmation prompt into the Validation callback flow

remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/it2me/it2me_confirmation_dialog_proxy.h"
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
 #include "base/run_loop.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gmock_mutant.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using ::testing::InvokeWithoutArgs;
 using ::testing::CreateFunctor;
 
 namespace remoting {
 
+namespace {
+const char kTestEmailAddress[] = "faux_remote_user@chromium_test.com";
+}  // namespace
+
 class StubIt2MeConfirmationDialog : public It2MeConfirmationDialog {
  public:
   explicit StubIt2MeConfirmationDialog(
       scoped_refptr<base::SingleThreadTaskRunner> task_runner)
       : task_runner_(task_runner) {
   }
   ~StubIt2MeConfirmationDialog() override {
     EXPECT_TRUE(task_runner_->BelongsToCurrentThread());
   }
 
   void ReportResult(Result result) {
     ASSERT_TRUE(task_runner_->BelongsToCurrentThread());
     callback_.Run(result);
   }
 
   MOCK_METHOD0(OnShow, void());
 
   // It2MeConfirmationDialog implementation.
-  void Show(const ResultCallback& callback) override {
+  void Show(const std::string& remote_user_email,
+            const ResultCallback& callback) override {
     EXPECT_TRUE(callback_.is_null());
     EXPECT_TRUE(task_runner_->BelongsToCurrentThread());
+    EXPECT_EQ(remote_user_email.compare(kTestEmailAddress), 0);
     callback_ = callback;
     OnShow();
   }
 
  private:
   scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
   ResultCallback callback_;
 };
 
 // Encapsulates a target for It2MeConfirmationDialog::ResultCallback.
@@ skipping 80 matching lines @@
               CreateFunctor(
                   &StubIt2MeConfirmationDialog::ReportResult,
                   base::Unretained(dialog()),
                   It2MeConfirmationDialog::Result::CANCEL)));
 
   EXPECT_CALL(callback_target,
               OnDialogResult(It2MeConfirmationDialog::Result::CANCEL))
       .WillOnce(
           InvokeWithoutArgs(this, &It2MeConfirmationDialogProxyTest::Quit));
 
-  dialog_proxy()->Show(callback_target.MakeCallback());
+  dialog_proxy()->Show(kTestEmailAddress, callback_target.MakeCallback());
 
   Run();
 }
 
 }  // namespace remoting