net/quic/core/quic_flags_list.h - Issue 2310273002: Deprecate FLAGS_quic_loss_recovery_use_largest_acked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/core/quic_flags_list.h

Issue 2310273002: Deprecate FLAGS_quic_loss_recovery_use_largest_acked. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/core/quic_flags_list.h

diff --git a/net/quic/core/quic_flags_list.h b/net/quic/core/quic_flags_list.h

index a95ea5c71fbf815402ab15a617326fcc35fc8706..8ffbba2dac72d9155c492bb650afee0e4282370c 100644

--- a/net/quic/core/quic_flags_list.h

+++ b/net/quic/core/quic_flags_list.h

@@ -63,10 +63,6 @@ QUIC_FLAG(bool, FLAGS_quic_never_write_unencrypted_data, true)

// of < 10 packets.

QUIC_FLAG(bool, FLAGS_quic_no_lower_bw_resumption_limit, true)

-// Use largest acked in the most recent ack instead of largest acked ever in

-// loss recovery.

-QUIC_FLAG(bool, FLAGS_quic_loss_recovery_use_largest_acked, true)

// Only set one alarm for sending at once, either the send alarm or

// retransmission alarm. Disabled because it breaks QUIC time loss detection.

QUIC_FLAG(bool, FLAGS_quic_only_one_sending_alarm, false)