Roll WebGL 3d0e045..2e13422

Roll WebGL 3d0e045..2e13422

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/3d0e045..2e13422

BUG=

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/4fa6dcdc7ef0f0bf608a40a4c3d01eca5a724142
Cr-Commit-Position: refs/heads/master@{#417329}

[yunchao, 2016-09-07 14:52:01]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 14:52:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 15:52:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 15:52:39]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[yunchao, 2016-09-07 23:42:13]

Description was changed from

==========
Roll WebGL 3d0e045..2e13422

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/3d0e04...

BUG=

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Roll WebGL 3d0e045..2e13422

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/3d0e04...

BUG=

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[yunchao, 2016-09-07 23:42:13]

yunchao.he@intel.com changed reviewers:
+ kbr@chromium.org, qiankun.miao@intel.com, zmo@chromium.org

[yunchao, 2016-09-07 23:47:06]

Roll in conformance tests about blitFramebuffer... 

Hi Zhenyao and Ken, could you help to take a look into the
{win|android}_optional_gpu_test_rel? How can I setFail for
webgl_conformance_gl_tests failure in win gpu bot, and failure for android gpu
bot? 

Well, the failure for {win|mac|linux}_chromium_rel_ng is not related to this
change. I should not run these bots.

[Zhenyao Mo, 2016-09-08 00:08:44]

On 2016/09/07 23:47:06, yunchao wrote:
> Roll in conformance tests about blitFramebuffer... 
> 
> Hi Zhenyao and Ken, could you help to take a look into the
> {win|android}_optional_gpu_test_rel? How can I setFail for
> webgl_conformance_gl_tests failure in win gpu bot, and failure for android gpu
> bot? 
> 
> Well, the failure for {win|mac|linux}_chromium_rel_ng is not related to this
> change. I should not run these bots.

That is webgl_conformance_expectations.py and use modifier 'opengl'

[Zhenyao Mo, 2016-09-08 00:09:34]

On 2016/09/08 00:08:44, Zhenyao Mo wrote:
> On 2016/09/07 23:47:06, yunchao wrote:
> > Roll in conformance tests about blitFramebuffer... 
> > 
> > Hi Zhenyao and Ken, could you help to take a look into the
> > {win|android}_optional_gpu_test_rel? How can I setFail for
> > webgl_conformance_gl_tests failure in win gpu bot, and failure for android
gpu
> > bot? 
> > 
> > Well, the failure for {win|mac|linux}_chromium_rel_ng is not related to this
> > change. I should not run these bots.
> 
> That is webgl_conformance_expectations.py and use modifier 'opengl'

No it is related to this change.  They are WebGL1 failures and you should update
the file I just mentioned.

[Ken Russell (switch to Gerrit), 2016-09-08 00:12:57]

On 2016/09/08 00:08:44, Zhenyao Mo wrote:
> On 2016/09/07 23:47:06, yunchao wrote:
> > Roll in conformance tests about blitFramebuffer... 
> > 
> > Hi Zhenyao and Ken, could you help to take a look into the
> > {win|android}_optional_gpu_test_rel? How can I setFail for
> > webgl_conformance_gl_tests failure in win gpu bot, and failure for android
gpu
> > bot? 
> > 
> > Well, the failure for {win|mac|linux}_chromium_rel_ng is not related to this
> > change. I should not run these bots.
> 
> That is webgl_conformance_expectations.py and use modifier 'opengl'

The _chromium_rel_ng failures are related to this roll. See
http://crbug.com/644957 . A suppression needs to be added and the validation
code in WebGL{2}RenderingContextBase needs to be updated to treat deleted
objects differently. Would you like to take that bug?

[yunchao, 2016-09-08 00:17:46]

On 2016/09/08 00:12:57, Ken Russell wrote:
> On 2016/09/08 00:08:44, Zhenyao Mo wrote:
> > On 2016/09/07 23:47:06, yunchao wrote:
> > > Roll in conformance tests about blitFramebuffer... 
> > > 
> > > Hi Zhenyao and Ken, could you help to take a look into the
> > > {win|android}_optional_gpu_test_rel? How can I setFail for
> > > webgl_conformance_gl_tests failure in win gpu bot, and failure for android
> gpu
> > > bot? 
> > > 
> > > Well, the failure for {win|mac|linux}_chromium_rel_ng is not related to
this
> > > change. I should not run these bots.
> > 
> > That is webgl_conformance_expectations.py and use modifier 'opengl'
> 
> The _chromium_rel_ng failures are related to this roll. See
> http://crbug.com/644957 . A suppression needs to be added and the validation
> code in WebGL{2}RenderingContextBase needs to be updated to treat deleted
> objects differently. Would you like to take that bug?

No problem. I can take a look at that issue. And maybe guide Yizhou to fix it.

[yunchao, 2016-09-08 05:32:11]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 05:32:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 07:11:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 07:11:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yunchao, 2016-09-08 07:22:28]

Patchset #3 (id:40001) has been deleted

[yunchao, 2016-09-08 07:22:36]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 07:22:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 08:12:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 08:12:50]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[yunchao, 2016-09-08 16:24:11]

On 2016/09/08 00:09:34, Zhenyao Mo wrote:
> On 2016/09/08 00:08:44, Zhenyao Mo wrote:
> > On 2016/09/07 23:47:06, yunchao wrote:
> > > Roll in conformance tests about blitFramebuffer... 
> > > 
> > > Hi Zhenyao and Ken, could you help to take a look into the
> > > {win|android}_optional_gpu_test_rel? How can I setFail for
> > > webgl_conformance_gl_tests failure in win gpu bot, and failure for android
> gpu
> > > bot? 
> > > 
> > > Well, the failure for {win|mac|linux}_chromium_rel_ng is not related to
this
> > > change. I should not run these bots.
> > 
> > That is webgl_conformance_expectations.py and use modifier 'opengl'
> 
> No it is related to this change.  They are WebGL1 failures and you should
update
> the file I just mentioned.

That's true.  WebGL 1 conformance test expectation has been updated, PTAL.
Thanks!

[Zhenyao Mo, 2016-09-08 16:29:19]

On 2016/09/08 16:24:11, yunchao wrote:
> On 2016/09/08 00:09:34, Zhenyao Mo wrote:
> > On 2016/09/08 00:08:44, Zhenyao Mo wrote:
> > > On 2016/09/07 23:47:06, yunchao wrote:
> > > > Roll in conformance tests about blitFramebuffer... 
> > > > 
> > > > Hi Zhenyao and Ken, could you help to take a look into the
> > > > {win|android}_optional_gpu_test_rel? How can I setFail for
> > > > webgl_conformance_gl_tests failure in win gpu bot, and failure for
android
> > gpu
> > > > bot? 
> > > > 
> > > > Well, the failure for {win|mac|linux}_chromium_rel_ng is not related to
> this
> > > > change. I should not run these bots.
> > > 
> > > That is webgl_conformance_expectations.py and use modifier 'opengl'
> > 
> > No it is related to this change.  They are WebGL1 failures and you should
> update
> > the file I just mentioned.
> 
> That's true.  WebGL 1 conformance test expectation has been updated, PTAL.
> Thanks!

lgtm

[yunchao, 2016-09-08 16:32:21]

The CQ bit was checked by yunchao.he@intel.com

[commit-bot: I haz the power, 2016-09-08 16:32:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 17:45:36]

Description was changed from

==========
Roll WebGL 3d0e045..2e13422

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/3d0e04...

BUG=

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Roll WebGL 3d0e045..2e13422

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/3d0e04...

BUG=

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-08 17:45:38]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-08 17:47:29]

Description was changed from

==========
Roll WebGL 3d0e045..2e13422

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/3d0e04...

BUG=

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Roll WebGL 3d0e045..2e13422

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/3d0e04...

BUG=

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/4fa6dcdc7ef0f0bf608a40a4c3d01eca5a724142
Cr-Commit-Position: refs/heads/master@{#417329}
==========

[commit-bot: I haz the power, 2016-09-08 17:47:34]

Patchset 3 (id:??) landed as
https://crrev.com/4fa6dcdc7ef0f0bf608a40a4c3d01eca5a724142
Cr-Commit-Position: refs/heads/master@{#417329}