Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 231023006: Omnibox: Remove HQP Default Match Line that isn't true (Closed)

Created:
6 years, 8 months ago by Mark P
Modified:
6 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

Omnibox: Remove HQP Default Match Line that isn't true HistoryQuick provider can provide what-you-typed scores (i.e., things that are allowed to be the default match despite prevent_inline_autocomplete being true) that is higher than HistoryURL provider's what-you-typed score. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/browser/autocomplete/history_quick_provider.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark P
ptal
6 years, 8 months ago (2014-04-09 19:40:38 UTC) #1
Peter Kasting
LGTM
6 years, 8 months ago (2014-04-09 20:41:39 UTC) #2
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 8 months ago (2014-04-09 20:45:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/231023006/1
6 years, 8 months ago (2014-04-09 20:46:32 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 23:29:15 UTC) #5
Message was sent while issue was closed.
Change committed as 262854

Powered by Google App Engine
This is Rietveld 408576698