Issue 231023005: Replace string comparing to enum comparing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 231023005: Replace string comparing to enum comparing. (Closed)

Created:
6 years, 8 months ago by KhNo

Modified:
6 years, 8 months ago

Reviewers:
Raymond Toy (Google), Raymond Toy

CC:
blink-reviews, Raymond Toy

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Replace string comparing to enum comparing. since process() is executed frequently, enum comparing to find panningModel is better than string comparing. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171168

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix nit #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/modules/webaudio/PannerNode.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Raymond Toy

lgtm with nit. https://codereview.chromium.org/231023005/diff/1/Source/modules/webaudio/PannerNode.cpp File Source/modules/webaudio/PannerNode.cpp (right): https://codereview.chromium.org/231023005/diff/1/Source/modules/webaudio/PannerNode.cpp#newcode130 Source/modules/webaudio/PannerNode.cpp:130: // HRTFDatabase should be loaded before ...

6 years, 8 months ago (2014-04-09 17:50:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/231023005/20001

6 years, 8 months ago (2014-04-09 17:54:44 UTC) #4

Message was sent while issue was closed.

Change committed as 171168

Expand Messages | Collapse Messages