Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2666)

Unified Diff: build/common.gypi

Issue 231023002: Fix the condition to disable the warning when building with Xcode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index f363b660403e20d78772f4d0a90828752defd9bf..46b2e8cdd844a94a0f78b9f221c8b5bf8c2bbbbd 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -4340,7 +4340,7 @@
],
}],
['OS=="ios" and target_subarch!="arm32" and \
- "<(GENERATOR)"=="ninja"', {
+ "<(GENERATOR)"=="xcode"', {
'OTHER_CFLAGS': [
# TODO(ios): when building Chrome for iOS on 64-bit platform
# with Xcode, the -Wshorted-64-to-32 warning is automatically
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698