Issue 231023002: Fix the condition to disable the warning when building with Xcode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 231023002: Fix the condition to disable the warning when building with Xcode (Closed)

Created:
6 years, 8 months ago by sdefresne

Modified:
6 years, 8 months ago

Reviewers:
droger

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix the condition to disable the warning when building with Xcode The warning -Wshorten-64-to-32 is automatically enabled by Xcode 5.1 when building for 64-bit architecture. Disable when the generator is Xcode, not ninja. BUG=359107 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262805

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/231023002/1

6 years, 8 months ago (2014-04-09 17:16:01 UTC) #4

Message was sent while issue was closed.

Change committed as 262805

Expand Messages | Collapse Messages