Issue 2310203002: Invalidate scrolling contents layer background when child invalidated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2310203002: Invalidate scrolling contents layer background when child invalidated. (Closed)

Created:
4 years, 3 months ago by flackr

Modified:
4 years, 3 months ago

Reviewers:
chrishtr

CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Invalidate scrolling contents layer background when child invalidated. BUG=643741 TEST=paint/invalidation/selection-within-opaque-composited-scroller.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -5 lines)			Patch
A +	third_party/WebKit/LayoutTests/paint/invalidation/selection-within-opaque-composited-scroller.html	View	1 chunk	+11 lines, -4 lines	0 comments	Download
A +	third_party/WebKit/LayoutTests/paint/invalidation/selection-within-opaque-composited-scroller-expected.txt	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

flackr

4 years, 3 months ago (2016-09-06 19:30:34 UTC) #3

Hey Chris,

I was having a closer look at exactly what the difference was in this particular
test case. It seems that a child of the composited scroller is updated, and then
we have an invalid display item on the composited scroller. Does it make sense
that we would need to invalidate the composited scroller when it paints the
background and a child of it is updated? This does fix my test case.

PTAL, thanks.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages