Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1404)

Unified Diff: Source/core/rendering/svg/SVGInlineTextBox.cpp

Issue 23102018: Refactoring DrawLooper so that it can apply shadow effects as skia image filters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: updated baselines and expectations Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/svg/SVGInlineTextBox.cpp
diff --git a/Source/core/rendering/svg/SVGInlineTextBox.cpp b/Source/core/rendering/svg/SVGInlineTextBox.cpp
index 8731b0c493186eea9fbff000bb0f91b141757b3d..f8b8703f67726e46581cf5efae0e95770510625a 100644
--- a/Source/core/rendering/svg/SVGInlineTextBox.cpp
+++ b/Source/core/rendering/svg/SVGInlineTextBox.cpp
@@ -625,14 +625,14 @@ void SVGInlineTextBox::paintTextWithShadows(GraphicsContext* context, RenderStyl
}
if (hasShadow) {
- DrawLooper drawLooper;
+ RefPtr<DrawLooper> drawLooper(new DrawLooper);
do {
FloatSize offset(shadow->x(), shadow->y());
- drawLooper.addShadow(offset, shadow->blur(), textRenderer->resolveColor(shadow->color(), Color::stdShadowColor),
+ drawLooper->addShadow(offset, shadow->blur(), textRenderer->resolveColor(shadow->color(), Color::stdShadowColor),
DrawLooper::ShadowRespectsTransforms, DrawLooper::ShadowRespectsAlpha);
} while ((shadow = shadow->next()));
- drawLooper.addUnmodifiedContent();
- context->setDrawLooper(drawLooper);
+ drawLooper->addUnmodifiedContent();
+ context->setDrawLooper(drawLooper.release());
}
if (prepareGraphicsContextForTextPainting(context, scalingFactor, textRun, style)) {

Powered by Google App Engine
This is Rietveld 408576698