Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 23102009: Revert 218616 "[net/dns] Perform A/AAAA queries for AF_UNSPEC re..." (Closed)

Created:
7 years, 4 months ago by mmenke
Modified:
7 years, 4 months ago
Reviewers:
mmenke
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 218616 "[net/dns] Perform A/AAAA queries for AF_UNSPEC re..." This was causing crashes in the case of DNS responses with no addresses. > [net/dns] Perform A/AAAA queries for AF_UNSPEC resolutions in parallel. > > The second DnsTransaction is scheduled as a second job on the resolver's > PrioritizedDispatcher, at the beginning of its priority queue. The two > DnsTransactions run independently of each other, although if one of them > finishes with an error, the other one will be scrapped immediately, and > the Job will fall back to ProcTask. > > BUG=174992 > > Review URL: https://chromiumcodereview.appspot.com/19498003 TBR=mmenke@chromium.org BUG=277625 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -776 lines) Patch
M trunk/src/chrome/browser/net/dns_probe_test_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/net/base/prioritized_dispatcher.h View 2 chunks +0 lines, -13 lines 0 comments Download
M trunk/src/net/base/prioritized_dispatcher.cc View 4 chunks +11 lines, -33 lines 0 comments Download
M trunk/src/net/base/prioritized_dispatcher_unittest.cc View 5 chunks +10 lines, -117 lines 0 comments Download
M trunk/src/net/base/priority_queue.h View 2 chunks +0 lines, -21 lines 0 comments Download
M trunk/src/net/base/priority_queue_unittest.cc View 2 chunks +1 line, -16 lines 0 comments Download
MM trunk/src/net/dns/dns_test_util.h View 3 chunks +5 lines, -30 lines 0 comments Download
MM trunk/src/net/dns/dns_test_util.cc View 7 chunks +46 lines, -65 lines 0 comments Download
M trunk/src/net/dns/host_resolver_impl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M trunk/src/net/dns/host_resolver_impl.cc View 20 chunks +99 lines, -211 lines 0 comments Download
M trunk/src/net/dns/host_resolver_impl_unittest.cc View 10 chunks +47 lines, -263 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mmenke
7 years, 4 months ago (2013-08-22 16:04:48 UTC) #1
mmenke
7 years, 4 months ago (2013-08-22 16:05:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r219027.

Powered by Google App Engine
This is Rietveld 408576698