Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: log_parser/perf_expectations/tests/perf_expectations_unittest.py

Issue 231017: Expectations for 3 perf systems on morejs and startup.... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/tools/buildbot/scripts/master/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « log_parser/perf_expectations/perf_expectations.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: log_parser/perf_expectations/tests/perf_expectations_unittest.py
===================================================================
--- log_parser/perf_expectations/tests/perf_expectations_unittest.py (revision 27063)
+++ log_parser/perf_expectations/tests/perf_expectations_unittest.py (working copy)
@@ -121,6 +121,8 @@
for key in perf_data:
if key == 'load':
continue
+ # tools/buildbot/scripts/master/log_parser.py should have a matching
+ # regular expression.
if not re.match(r"^([\w\.-]+)/([\w\.-]+)/([\w\.-]+)/([\w\.-]+)$", key):
bad_keys.append(key)
if len(bad_keys) > 0:
« no previous file with comments | « log_parser/perf_expectations/perf_expectations.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698