Chromium Code Reviews| Index: src/heap/gc-tracer.h |
| diff --git a/src/heap/gc-tracer.h b/src/heap/gc-tracer.h |
| index b994d5c65800760320f620ba8807f4bd05cad6e4..56a018d32395a237decf13754e167a5ace1eaff2 100644 |
| --- a/src/heap/gc-tracer.h |
| +++ b/src/heap/gc-tracer.h |
| @@ -193,7 +193,8 @@ class GCTracer { |
| START = 3 |
| }; |
| - Event(Type type, const char* gc_reason, const char* collector_reason); |
| + Event(Type type, GarbageCollectionReason gc_reason, |
| + const char* collector_reason); |
| // Returns a string describing the event type. |
| const char* TypeName(bool short_name) const; |
| @@ -201,7 +202,7 @@ class GCTracer { |
| // Type of event |
| Type type; |
| - const char* gc_reason; |
| + GarbageCollectionReason gc_reason; |
| const char* collector_reason; |
| // Timestamp set in the constructor. |
| @@ -271,7 +272,7 @@ class GCTracer { |
| explicit GCTracer(Heap* heap); |
| // Start collecting data. |
| - void Start(GarbageCollector collector, const char* gc_reason, |
| + void Start(GarbageCollector collector, GarbageCollectionReason gc_reason, |
| const char* collector_reason); |
| // Stop collecting data and print results. |
| @@ -394,6 +395,9 @@ class GCTracer { |
| } |
| } |
| + static const char* GarbageCollectionReasonToString( |
|
Michael Lippautz
2016/09/07 07:28:31
nit: I would move the function somewhere into heap
ulan
2016/09/07 09:25:12
Done.
|
| + GarbageCollectionReason gc_reason); |
| + |
| private: |
| FRIEND_TEST(GCTracer, AverageSpeed); |
| FRIEND_TEST(GCTracerTest, AllocationThroughput); |