Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: sync/js/sync_js_controller.cc

Issue 231013003: Remove Sync JS generic request/reply framework (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove js_reply_handler.h from gyp Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sync/js/sync_js_controller.h ('k') | sync/js/sync_js_controller_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/js/sync_js_controller.h" 5 #include "sync/js/sync_js_controller.h"
6 6
7 #include "base/location.h" 7 #include "base/location.h"
8 #include "sync/js/js_backend.h" 8 #include "sync/js/js_backend.h"
9 #include "sync/js/js_event_details.h" 9 #include "sync/js/js_event_details.h"
10 10
11 namespace syncer { 11 namespace syncer {
12 12
13 SyncJsController::PendingJsMessage::PendingJsMessage(
14 const std::string& name, const JsArgList& args,
15 const WeakHandle<JsReplyHandler>& reply_handler)
16 : name(name), args(args), reply_handler(reply_handler) {}
17
18 SyncJsController::PendingJsMessage::~PendingJsMessage() {}
19
20 SyncJsController::SyncJsController() {} 13 SyncJsController::SyncJsController() {}
21 14
22 SyncJsController::~SyncJsController() { 15 SyncJsController::~SyncJsController() {
23 AttachJsBackend(WeakHandle<JsBackend>()); 16 AttachJsBackend(WeakHandle<JsBackend>());
24 } 17 }
25 18
26 void SyncJsController::AddJsEventHandler(JsEventHandler* event_handler) { 19 void SyncJsController::AddJsEventHandler(JsEventHandler* event_handler) {
27 js_event_handlers_.AddObserver(event_handler); 20 js_event_handlers_.AddObserver(event_handler);
28 UpdateBackendEventHandler(); 21 UpdateBackendEventHandler();
29 } 22 }
30 23
31 void SyncJsController::RemoveJsEventHandler(JsEventHandler* event_handler) { 24 void SyncJsController::RemoveJsEventHandler(JsEventHandler* event_handler) {
32 js_event_handlers_.RemoveObserver(event_handler); 25 js_event_handlers_.RemoveObserver(event_handler);
33 UpdateBackendEventHandler(); 26 UpdateBackendEventHandler();
34 } 27 }
35 28
36 void SyncJsController::AttachJsBackend( 29 void SyncJsController::AttachJsBackend(
37 const WeakHandle<JsBackend>& js_backend) { 30 const WeakHandle<JsBackend>& js_backend) {
38 js_backend_ = js_backend; 31 js_backend_ = js_backend;
39 UpdateBackendEventHandler(); 32 UpdateBackendEventHandler();
40
41 if (js_backend_.IsInitialized()) {
42 // Process any queued messages.
43 for (PendingJsMessageList::const_iterator it =
44 pending_js_messages_.begin();
45 it != pending_js_messages_.end(); ++it) {
46 js_backend_.Call(FROM_HERE, &JsBackend::ProcessJsMessage,
47 it->name, it->args, it->reply_handler);
48 }
49 }
50 }
51
52 void SyncJsController::ProcessJsMessage(
53 const std::string& name, const JsArgList& args,
54 const WeakHandle<JsReplyHandler>& reply_handler) {
55 if (js_backend_.IsInitialized()) {
56 js_backend_.Call(FROM_HERE, &JsBackend::ProcessJsMessage,
57 name, args, reply_handler);
58 } else {
59 pending_js_messages_.push_back(
60 PendingJsMessage(name, args, reply_handler));
61 }
62 } 33 }
63 34
64 void SyncJsController::HandleJsEvent(const std::string& name, 35 void SyncJsController::HandleJsEvent(const std::string& name,
65 const JsEventDetails& details) { 36 const JsEventDetails& details) {
66 FOR_EACH_OBSERVER(JsEventHandler, js_event_handlers_, 37 FOR_EACH_OBSERVER(JsEventHandler, js_event_handlers_,
67 HandleJsEvent(name, details)); 38 HandleJsEvent(name, details));
68 } 39 }
69 40
70 void SyncJsController::UpdateBackendEventHandler() { 41 void SyncJsController::UpdateBackendEventHandler() {
71 if (js_backend_.IsInitialized()) { 42 if (js_backend_.IsInitialized()) {
72 // To avoid making the backend send useless events, we clear the 43 // To avoid making the backend send useless events, we clear the
73 // event handler we pass to it if we don't have any event 44 // event handler we pass to it if we don't have any event
74 // handlers. 45 // handlers.
75 WeakHandle<JsEventHandler> backend_event_handler = 46 WeakHandle<JsEventHandler> backend_event_handler =
76 js_event_handlers_.might_have_observers() ? 47 js_event_handlers_.might_have_observers() ?
77 MakeWeakHandle(AsWeakPtr()) : WeakHandle<SyncJsController>(); 48 MakeWeakHandle(AsWeakPtr()) : WeakHandle<SyncJsController>();
78 js_backend_.Call(FROM_HERE, &JsBackend::SetJsEventHandler, 49 js_backend_.Call(FROM_HERE, &JsBackend::SetJsEventHandler,
79 backend_event_handler); 50 backend_event_handler);
80 } 51 }
81 } 52 }
82 53
83 } // namespace syncer 54 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/js/sync_js_controller.h ('k') | sync/js/sync_js_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698