Issue 231013002: Introduce LoadSharedFunctionInfoSpecialField for x64 port.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 231013002: Introduce LoadSharedFunctionInfoSpecialField for x64 port. (Closed)

Created:
6 years, 8 months ago by haitao.feng

Modified:
6 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Introduce LoadSharedFunctionInfoSpecialField for x64 port. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20636

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -15 lines)			Patch
M	src/x64/builtins-x64.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	3 chunks	+31 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

haitao.feng

Those SharedFunctionInfo fields are special as they are SMIs for x32 port and are at ...

6 years, 8 months ago (2014-04-09 15:13:42 UTC) #1

haitao.feng

Committed patchset #1 manually as r20636 (presubmit successful).

6 years, 8 months ago (2014-04-10 02:12:06 UTC) #3

haitao.feng

6 years, 8 months ago (2014-04-10 03:47:32 UTC) #4

Message was sent while issue was closed.

We have buildbot failures for this commit. Mac64 failed on
cctest/test-api/Threading1, but I could not reproduce it locally on Mac. For the
layout buildbot failures, it seems that they failed on ia32 port.

Expand Messages | Collapse Messages